<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/16481">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rach_pass_filter(): Add information about channel type<br><br>When logging about filtering access bursts, let's indicate if this is<br>on a CCCH, PDCH or handover related.<br><br>Change-Id: I03f21f2b54cbe5aad36ac71a614d5df98867df80<br>---<br>M src/common/l1sap.c<br>1 file changed, 11 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index e640ce9..213099d 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1337,14 +1337,15 @@</span><br><span> </span><br><span> #define RACH_MIN_TOA256 -2 * 256</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static bool rach_pass_filter(struct ph_rach_ind_param *rach_ind, struct gsm_bts *bts)</span><br><span style="color: hsl(120, 100%, 40%);">+static bool rach_pass_filter(struct ph_rach_ind_param *rach_ind, struct gsm_bts *bts,</span><br><span style="color: hsl(120, 100%, 40%);">+                            const char *chan_name)</span><br><span> {</span><br><span>     int16_t toa256 = rach_ind->acc_delay_256bits;</span><br><span> </span><br><span>         /* Check for RACH exceeding BER threshold (ghost RACH) */</span><br><span>    if (rach_ind->ber10k > bts->max_ber10k_rach) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst: "</span><br><span style="color: hsl(0, 100%, 40%);">-                 "BER10k(%u) > BER10k_MAX(%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst on %s: "</span><br><span style="color: hsl(120, 100%, 40%);">+                 "BER10k(%u) > BER10k_MAX(%u)\n", chan_name,</span><br><span>                     rach_ind->ber10k, bts->max_ber10k_rach);</span><br><span>               return false;</span><br><span>        }</span><br><span>@@ -1355,16 +1356,16 @@</span><br><span>   * according to maximal allowed Timing Advance value.</span><br><span>         */</span><br><span>  if (toa256 < RACH_MIN_TOA256 || toa256 > bts->max_ta * 256) {</span><br><span style="color: hsl(0, 100%, 40%);">-          LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst: "</span><br><span style="color: hsl(0, 100%, 40%);">-                 "ToA(%d) exceeds the allowed range (%d..%d)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst on %s: "</span><br><span style="color: hsl(120, 100%, 40%);">+                 "ToA(%d) exceeds the allowed range (%d..%d)\n", chan_name,</span><br><span>                         toa256, RACH_MIN_TOA256, bts->max_ta * 256);</span><br><span>              return false;</span><br><span>        }</span><br><span> </span><br><span>        /* Link quality defined by C/I (Carrier-to-Interference ratio) */</span><br><span>    if (rach_ind->lqual_cb < bts->min_qual_rach) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst: "</span><br><span style="color: hsl(0, 100%, 40%);">-                 "link quality (%d) below the minimum (%d)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst on %s: "</span><br><span style="color: hsl(120, 100%, 40%);">+                 "link quality (%d) below the minimum (%d)\n", chan_name,</span><br><span>                   rach_ind->lqual_cb, bts->min_qual_rach);</span><br><span>               return false;</span><br><span>        }</span><br><span>@@ -1376,7 +1377,7 @@</span><br><span> static int l1sap_handover_rach(struct gsm_bts_trx *trx, struct ph_rach_ind_param *rach_ind)</span><br><span> {</span><br><span>        /* Filter out noise / interference / ghosts */</span><br><span style="color: hsl(0, 100%, 40%);">-  if (!rach_pass_filter(rach_ind, trx->bts)) {</span><br><span style="color: hsl(120, 100%, 40%);">+       if (!rach_pass_filter(rach_ind, trx->bts, "handover")) {</span><br><span>                rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_DROP);</span><br><span>              return 0;</span><br><span>    }</span><br><span>@@ -1392,7 +1393,7 @@</span><br><span> static int l1sap_pdch_rach(struct gsm_bts_trx *trx, struct ph_rach_ind_param *rach_ind)</span><br><span> {</span><br><span>    /* Filter out noise / interference / ghosts */</span><br><span style="color: hsl(0, 100%, 40%);">-  if (!rach_pass_filter(rach_ind, trx->bts))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!rach_pass_filter(rach_ind, trx->bts, "PDCH"))</span><br><span>              return -EAGAIN;</span><br><span> </span><br><span>  /* PTCCH/U (Packet Timing Advance Control Channel) */</span><br><span>@@ -1444,7 +1445,7 @@</span><br><span>                bts->load.rach.busy++;</span><br><span> </span><br><span>        /* Filter out noise / interference / ghosts */</span><br><span style="color: hsl(0, 100%, 40%);">-  if (!rach_pass_filter(rach_ind, bts)) {</span><br><span style="color: hsl(120, 100%, 40%);">+       if (!rach_pass_filter(rach_ind, bts, "CCCH")) {</span><br><span>            rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_DROP);</span><br><span>              return 0;</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/16481">change 16481</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/16481"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I03f21f2b54cbe5aad36ac71a614d5df98867df80 </div>
<div style="display:none"> Gerrit-Change-Number: 16481 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>