<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16453">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">exit(2) on unsupported positional arguments on command line<br><br>Change-Id: I6d4efa6ddef41607aecd5ceee78e400db821292f<br>---<br>M src/e1_recorder.c<br>M src/e1cap_dump.c<br>2 files changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/e1_recorder.c b/src/e1_recorder.c</span><br><span>index 9110ccb..d085ca5 100644</span><br><span>--- a/src/e1_recorder.c</span><br><span>+++ b/src/e1_recorder.c</span><br><span>@@ -123,6 +123,11 @@</span><br><span>                        break;</span><br><span>               }</span><br><span>    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (argc > optind) {</span><br><span style="color: hsl(120, 100%, 40%);">+               fprintf(stderr, "Unsupported positional arguments on command line\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span> }</span><br><span> </span><br><span> int main(int argc, char **argv)</span><br><span>diff --git a/src/e1cap_dump.c b/src/e1cap_dump.c</span><br><span>index c172b55..73be84b 100644</span><br><span>--- a/src/e1cap_dump.c</span><br><span>+++ b/src/e1cap_dump.c</span><br><span>@@ -275,6 +275,11 @@</span><br><span>            exit(2);</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (argc > optind+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+             fprintf(stderr, "Unsupported positional arguments on command line\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  f = osmo_e1cap_open(NULL, argv[optind++]);</span><br><span>   if (!f) {</span><br><span>            fprintf(stderr, "Unable to open input file\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16453">change 16453</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16453"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-recorder </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6d4efa6ddef41607aecd5ceee78e400db821292f </div>
<div style="display:none"> Gerrit-Change-Number: 16453 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>