<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Fix incorrect FN being send over PCUIF to PCU<br><br>The event FN contains the current FN, but the message should contain the<br>FN of the first burst of the block.<br><br>Change-Id: Iba0b1d1a3d7d875c5443a7bcaff399f9681624ad<br>---<br>M pcu/PCUIF_RAW_Components.ttcn<br>1 file changed, 8 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/16486/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCUIF_RAW_Components.ttcn b/pcu/PCUIF_RAW_Components.ttcn</span><br><span>index 6d29404..0f28839 100644</span><br><span>--- a/pcu/PCUIF_RAW_Components.ttcn</span><br><span>+++ b/pcu/PCUIF_RAW_Components.ttcn</span><br><span>@@ -278,6 +278,7 @@</span><br><span> runs on RAW_PCU_BTS_CT {</span><br><span>      var PCUIF_Message pcu_msg;</span><br><span>   var RAW_PCU_Event event;</span><br><span style="color: hsl(120, 100%, 40%);">+      var integer ev_begin_fn;</span><br><span> </span><br><span>         [] CLCK.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_BEG)) -> value event {</span><br><span>          /* If the RTS queue for PDTCH is not empty, send a message */</span><br><span>@@ -296,23 +297,27 @@</span><br><span>                repeat;</span><br><span>              }</span><br><span>    [lengthof(pdtch_data_queue) > 0] CLCK.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_END)) -> value event {</span><br><span style="color: hsl(120, 100%, 40%);">+          /* FN matching the beginning of current block: */</span><br><span style="color: hsl(120, 100%, 40%);">+             ev_begin_fn := event.data.tdma_fn - 3;</span><br><span>               /* Dequeue a DATA.ind message */</span><br><span>             f_PCUIF_MsgQueue_dequeue(pdtch_data_queue, pcu_msg);</span><br><span> </span><br><span>             /* Patch TDMA frame / block number */</span><br><span style="color: hsl(0, 100%, 40%);">-           pcu_msg.u.data_ind.fn := event.data.tdma_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+          pcu_msg.u.data_ind.fn := ev_begin_fn;</span><br><span>                pcu_msg.u.data_ind.block_nr := 0; /* FIXME! */</span><br><span> </span><br><span>           PCUIF.send(pcu_msg); /* Send to the PCU and notify the TC */</span><br><span style="color: hsl(0, 100%, 40%);">-            TC.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_SENT, event.data.tdma_fn));</span><br><span style="color: hsl(120, 100%, 40%);">+            TC.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_SENT, ev_begin_fn));</span><br><span>          repeat;</span><br><span>              }</span><br><span>    [lengthof(ptcch_rts_queue) > 0] CLCK.receive(tr_RAW_PCU_EV(TDMA_EV_PTCCH_DL_BLOCK)) -> value event {</span><br><span style="color: hsl(120, 100%, 40%);">+            /* FN matching the beginning of current block: */</span><br><span style="color: hsl(120, 100%, 40%);">+             ev_begin_fn := event.data.tdma_fn - 3;</span><br><span>               /* Dequeue an RTS.req message for PTCCH */</span><br><span>           f_PCUIF_MsgQueue_dequeue(ptcch_rts_queue, pcu_msg);</span><br><span> </span><br><span>              /* Patch TDMA frame / block number and send */</span><br><span style="color: hsl(0, 100%, 40%);">-          pcu_msg.u.rts_req.fn := event.data.tdma_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+           pcu_msg.u.rts_req.fn := ev_begin_fn;</span><br><span>                 pcu_msg.u.rts_req.block_nr := 0; /* FIXME! */</span><br><span>                PCUIF.send(pcu_msg);</span><br><span>                 repeat;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486">change 16486</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iba0b1d1a3d7d875c5443a7bcaff399f9681624ad </div>
<div style="display:none"> Gerrit-Change-Number: 16486 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>