<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/16490">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bankd: initialize bank_id/slot_nr to 0xffff for unmapped workers<br><br>Otherwise the loop for SIGMAPDEL delivery code will match any<br>unused worker for bank_id=0/slot_nr=0, which is not what we want.<br><br>This also makes repeated RemsimBankd_Tests.TC_removeMapping_connected<br>runs work reliably.<br><br>Change-Id: I6976eb96feae6a3b66bacf787e436a2df29f9ce0<br>---<br>M src/bankd/bankd_main.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/90/16490/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c</span><br><span>index 94227e3..09a9e1d 100644</span><br><span>--- a/src/bankd/bankd_main.c</span><br><span>+++ b/src/bankd/bankd_main.c</span><br><span>@@ -411,6 +411,8 @@</span><br><span> {</span><br><span>  LOGW(g_worker, "SIGMAPDEL received: Main thread informs us our map is gone\n");</span><br><span>    OSMO_ASSERT(sig == SIGMAPDEL);</span><br><span style="color: hsl(120, 100%, 40%);">+        g_worker->slot.bank_id = 0xffff;</span><br><span style="color: hsl(120, 100%, 40%);">+   g_worker->slot.slot_nr = 0xffff;</span><br><span>  worker_set_state(g_worker, BW_ST_CONN_CLIENT_UNMAPPED);</span><br><span> }</span><br><span> </span><br><span>@@ -852,6 +854,9 @@</span><br><span>       /* push cleanup helper */</span><br><span>    pthread_cleanup_push(&worker_cleanup, g_worker);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      g_worker->slot.bank_id = 0xffff;</span><br><span style="color: hsl(120, 100%, 40%);">+   g_worker->slot.slot_nr = 0xffff;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        /* we continuously perform the same loop here, recycling the worker thread</span><br><span>    * once the client connection is gone or we have some trouble with the card/reader */</span><br><span>        while (1) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/16490">change 16490</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/16490"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6976eb96feae6a3b66bacf787e436a2df29f9ce0 </div>
<div style="display:none"> Gerrit-Change-Number: 16490 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>