<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/16438">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl: Clarify when autnonoums MS Power Ctrl Loop is used<br><br>Simplify when the fixed field is set in rsl_rx_chan_activ.<br><br>Comment talks about enabling autonoumous control loop, but it is<br>actually describing it when disabling it, which is confusing.<br><br>Change-Id: Id6b444a33ab062f6dab11a0ce62d8aecaea87591<br>---<br>M src/common/rsl.c<br>1 file changed, 6 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/38/16438/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index 67eb622..b315d30 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1100,7 +1100,7 @@</span><br><span>    /* Initialize channel defaults */</span><br><span>    lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0);</span><br><span>      lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;</span><br><span style="color: hsl(0, 100%, 40%);">-  lchan->ms_power_ctrl.fixed = false;</span><br><span style="color: hsl(120, 100%, 40%);">+        lchan->ms_power_ctrl.fixed = true;</span><br><span> </span><br><span>    rsl_tlv_parse(&tp, msgb_l3(msg), msgb_l3len(msg));</span><br><span> </span><br><span>@@ -1152,7 +1152,6 @@</span><br><span>   if (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)) {</span><br><span>            lchan->ms_power_ctrl.max = *TLVP_VAL(&tp, RSL_IE_MS_POWER) & 0x1F;</span><br><span>                lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;</span><br><span style="color: hsl(0, 100%, 40%);">-          lchan->ms_power_ctrl.fixed = false;</span><br><span>       }</span><br><span>    /* 9.3.24 Timing Advance */</span><br><span>  if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1))</span><br><span>@@ -1160,13 +1159,11 @@</span><br><span> </span><br><span>  /* 9.3.32 BS Power Parameters */</span><br><span>     /* 9.3.31 MS Power Parameters */</span><br><span style="color: hsl(0, 100%, 40%);">-        if (TLVP_PRESENT(&tp, RSL_IE_MS_POWER_PARAM))</span><br><span style="color: hsl(0, 100%, 40%);">-               lchan->ms_power_ctrl.fixed = false;</span><br><span style="color: hsl(0, 100%, 40%);">-  else {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (TLVP_PRESENT(&tp, RSL_IE_MS_POWER_PARAM)) {</span><br><span>          /* Spec explicitly states BTS should only perform</span><br><span>            * autonomous MS power control loop in BTS if 'MS Power</span><br><span>           * Parameters' IE is present! */</span><br><span style="color: hsl(0, 100%, 40%);">-             lchan->ms_power_ctrl.fixed = true;</span><br><span style="color: hsl(120, 100%, 40%);">+         lchan->ms_power_ctrl.fixed = false;</span><br><span>       }</span><br><span>    /* 9.3.16 Physical Context */</span><br><span> </span><br><span>@@ -1637,12 +1634,12 @@</span><br><span>  LOGPLCHAN(lchan, DRSL, LOGL_INFO, "Rx MS POWER CONTROL %" PRIu8 "\n", pwr);</span><br><span> </span><br><span>  /* 9.3.31 MS Power Parameters (O) */</span><br><span style="color: hsl(0, 100%, 40%);">-    if (TLVP_PRESENT(&tp, RSL_IE_MS_POWER_PARAM))</span><br><span style="color: hsl(0, 100%, 40%);">-               lchan->ms_power_ctrl.fixed = false;</span><br><span style="color: hsl(0, 100%, 40%);">-  else {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (TLVP_PRESENT(&tp, RSL_IE_MS_POWER_PARAM)) {</span><br><span>          /* Spec explicitly states BTS should only perform</span><br><span>            * autonomous MS power control loop in BTS if 'MS Power</span><br><span>           * Parameters' IE is present! */</span><br><span style="color: hsl(120, 100%, 40%);">+           lchan->ms_power_ctrl.fixed = false;</span><br><span style="color: hsl(120, 100%, 40%);">+        } else {</span><br><span>             lchan->ms_power_ctrl.fixed = true;</span><br><span>        }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/16438">change 16438</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/16438"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id6b444a33ab062f6dab11a0ce62d8aecaea87591 </div>
<div style="display:none"> Gerrit-Change-Number: 16438 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>