<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/16434">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bankd: send IPA CCM ID_ACK after receiving ID_ACK<br><br>It is customary in the IPA protocol that a a server side<br>responds with an ID_ACK if the client sends an ID_ACK.  Due<br>to the lack of any protocol specification, it's unclear why<br>exactly, but we know it does happen.<br><br>osmo-remsim-bankd so far failed to implement this, which is<br>not directly a problem as the only user (osmo-remsim-client)<br>didn't care.  However, when executing TTCN3 test cases,<br>the IPA_Emulation expects that ID_ACK and related test fail.<br><br>Change-Id: Ie55c9d5c435df786e97ec3900837bb21ab80140a<br>---<br>M src/bankd/bankd_main.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/34/16434/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c</span><br><span>index 8cfeb96..9f99f83 100644</span><br><span>--- a/src/bankd/bankd_main.c</span><br><span>+++ b/src/bankd/bankd_main.c</span><br><span>@@ -747,6 +747,8 @@</span><br><span>                switch (hh->data[0]) {</span><br><span>            case IPAC_MSGT_PING:</span><br><span>                         return ipa_ccm_send_pong(worker->client.fd);</span><br><span style="color: hsl(120, 100%, 40%);">+               case IPAC_MSGT_ID_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+                        return ipa_ccm_send_id_ack(g_worker->client.fd);</span><br><span>          default:</span><br><span>                     LOGW(worker, "IPA CCM 0x%02x not implemented yet\n", hh->data[0]);</span><br><span>                      break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/16434">change 16434</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/16434"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie55c9d5c435df786e97ec3900837bb21ab80140a </div>
<div style="display:none"> Gerrit-Change-Number: 16434 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>