<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16441">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">GSUP_Types: Split RAT_TYPE_IE to SUPPORTED / CURRENT<br><br>We added the RAT_TYPE_IE while the respective change in libosmocore<br>was still in gerrit review. Meanwhile the support there has been<br>split into two parts: A list of supported radio access types and<br>another IE indicating the current RAT. Let's catch up with that<br>in the GSUP implementation.<br><br>This makes TC_gsup_sai_eps() pass again.<br><br>Change-Id: I2c609dc523cbec562c6c6a05f4c7d600649ff52d<br>---<br>M library/GSUP_Types.ttcn<br>1 file changed, 28 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn</span><br><span>index e1aa24c..8977d9f 100644</span><br><span>--- a/library/GSUP_Types.ttcn</span><br><span>+++ b/library/GSUP_Types.ttcn</span><br><span>@@ -43,7 +43,8 @@</span><br><span> OSMO_GSUP_AUTS_IE ('26'O),</span><br><span> OSMO_GSUP_RES_IE ('27'O),</span><br><span> OSMO_GSUP_CN_DOMAIN_IE ('28'O),</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_GSUP_RAT_TYPE_IE ('29'O),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_SUPPORTED_RAT_TYPES_IE ('29'O),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_CURRENT_RAT_TYPE_IE ('2a'O),</span><br><span> </span><br><span> OSMO_GSUP_SESSION_ID_IE ('30'O),</span><br><span> OSMO_GSUP_SESSION_STATE_IE ('31'O),</span><br><span>@@ -233,7 +234,8 @@</span><br><span> cause_rr, tag = OSMO_GSUP_CAUSE_RR_IE;</span><br><span> cause_bssap, tag = OSMO_GSUP_CAUSE_BSSAP_IE;</span><br><span> cause_sm, tag = OSMO_GSUP_CAUSE_SM_IE;</span><br><span style="color: hsl(0, 100%, 40%);">- rat_type, tag = OSMO_GSUP_RAT_TYPE_IE;</span><br><span style="color: hsl(120, 100%, 40%);">+ supported_rat_types, tag = OSMO_GSUP_SUPPORTED_RAT_TYPES_IE;</span><br><span style="color: hsl(120, 100%, 40%);">+ current_rat_type, tag = OSMO_GSUP_CURRENT_RAT_TYPE_IE;</span><br><span> )"</span><br><span> };</span><br><span> </span><br><span>@@ -300,7 +302,8 @@</span><br><span> OCT1 cause_bssap,</span><br><span> OCT1 cause_sm,</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- GSUP_RatTypes rat_type</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP_RatTypes supported_rat_types,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP_RatType current_rat_type</span><br><span> };</span><br><span> </span><br><span> type record GSUP_PDU {</span><br><span>@@ -449,7 +452,7 @@</span><br><span> template (value) GSUP_PDU ts_GSUP_SAI_REQ_EPS(hexstring imsi) :=</span><br><span> ts_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, {</span><br><span> valueof(ts_GSUP_IE_IMSI(imsi)),</span><br><span style="color: hsl(0, 100%, 40%);">- valueof(ts_GSUP_IE_RAT_TYPE({RAT_TYPE_EUTRAN_SGs}))</span><br><span style="color: hsl(120, 100%, 40%);">+ valueof(ts_GSUP_IE_CURRENT_RAT_TYPE(RAT_TYPE_EUTRAN_SGs))</span><br><span> });</span><br><span> </span><br><span> template GSUP_PDU tr_GSUP_SAI_REQ(template hexstring imsi) :=</span><br><span>@@ -1124,19 +1127,33 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-template (present) GSUP_IE tr_GSUP_IE_RAT_TYPE(template (present) GSUP_RatTypes ratt) := {</span><br><span style="color: hsl(0, 100%, 40%);">- tag := OSMO_GSUP_RAT_TYPE_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+template (present) GSUP_IE tr_GSUP_IE_SUPPORTED_RAT_TYPES(template (present) GSUP_RatTypes ratt) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ tag := OSMO_GSUP_SUPPORTED_RAT_TYPES_IE,</span><br><span> len := ?,</span><br><span> val := {</span><br><span style="color: hsl(0, 100%, 40%);">- rat_type := ratt</span><br><span style="color: hsl(120, 100%, 40%);">+ supported_rat_types := ratt</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-template (value) GSUP_IE ts_GSUP_IE_RAT_TYPE(GSUP_RatTypes ratt) := {</span><br><span style="color: hsl(0, 100%, 40%);">- tag := OSMO_GSUP_RAT_TYPE_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+template (value) GSUP_IE ts_GSUP_IE_SUPPORTED_RAT_TYPES(GSUP_RatTypes ratt) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ tag := OSMO_GSUP_SUPPORTED_RAT_TYPES_IE,</span><br><span> len := 0, /* overwritten */</span><br><span> val := {</span><br><span style="color: hsl(0, 100%, 40%);">- rat_type := ratt</span><br><span style="color: hsl(120, 100%, 40%);">+ supported_rat_types := ratt</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+template (present) GSUP_IE tr_GSUP_IE_CURRENT_RAT_TYPE(template (present) GSUP_RatType ratt) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ tag := OSMO_GSUP_CURRENT_RAT_TYPE_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+ len := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ val := {</span><br><span style="color: hsl(120, 100%, 40%);">+ current_rat_type := ratt</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+template (value) GSUP_IE ts_GSUP_IE_CURRENT_RAT_TYPE(GSUP_RatType ratt) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ tag := OSMO_GSUP_CURRENT_RAT_TYPE_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+ len := 0, /* overwritten */</span><br><span style="color: hsl(120, 100%, 40%);">+ val := {</span><br><span style="color: hsl(120, 100%, 40%);">+ current_rat_type := ratt</span><br><span> }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16441">change 16441</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16441"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2c609dc523cbec562c6c6a05f4c7d600649ff52d </div>
<div style="display:none"> Gerrit-Change-Number: 16441 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>