<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/16385">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">counters: clarify documentation for MSC_CTR_LOC_UPDATE_* entries<br><br>Change-Id: I4f4a0d644db0a2dd7c8eefd846ea6913c0b780ce<br>---<br>M doc/manuals/chapters/counters_generated.adoc<br>M include/osmocom/msc/gsm_data.h<br>2 files changed, 12 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc</span><br><span>index 526ed01..49f2589 100644</span><br><span>--- a/doc/manuals/chapters/counters_generated.adoc</span><br><span>+++ b/doc/manuals/chapters/counters_generated.adoc</span><br><span>@@ -10,12 +10,12 @@</span><br><span> [options="header"]</span><br><span> |===</span><br><span> | Name | Reference | Description</span><br><span style="color: hsl(0, 100%, 40%);">-| loc_update_type:attach | <<msc_loc_update_type:attach>> | Received location update imsi attach requests.</span><br><span style="color: hsl(0, 100%, 40%);">-| loc_update_type:normal | <<msc_loc_update_type:normal>> | Received location update normal requests.</span><br><span style="color: hsl(0, 100%, 40%);">-| loc_update_type:periodic | <<msc_loc_update_type:periodic>> | Received location update periodic requests.</span><br><span style="color: hsl(0, 100%, 40%);">-| loc_update_type:detach | <<msc_loc_update_type:detach>> | Received location update detach indication.</span><br><span style="color: hsl(0, 100%, 40%);">-| loc_update_resp:failed | <<msc_loc_update_resp:failed>> | Rejected location updates.</span><br><span style="color: hsl(0, 100%, 40%);">-| loc_update_resp:completed | <<msc_loc_update_resp:completed>> | Successful location updates.</span><br><span style="color: hsl(120, 100%, 40%);">+| loc_update_type:attach | <<msc_loc_update_type:attach>> | Received Location Update (IMSI Attach) requests.</span><br><span style="color: hsl(120, 100%, 40%);">+| loc_update_type:normal | <<msc_loc_update_type:normal>> | Received Location Update (LAC change) requests.</span><br><span style="color: hsl(120, 100%, 40%);">+| loc_update_type:periodic | <<msc_loc_update_type:periodic>> | Received (periodic) Location Update requests.</span><br><span style="color: hsl(120, 100%, 40%);">+| loc_update_type:detach | <<msc_loc_update_type:detach>> | Received IMSI Detach indications.</span><br><span style="color: hsl(120, 100%, 40%);">+| loc_update_resp:failed | <<msc_loc_update_resp:failed>> | Rejected Location Updates requests.</span><br><span style="color: hsl(120, 100%, 40%);">+| loc_update_resp:completed | <<msc_loc_update_resp:completed>> | Successful Location Update procedures.</span><br><span> | cm_service_request:rejected | <<msc_cm_service_request:rejected>> | Rejected CM Service Request.</span><br><span> | cm_service_request:accepted | <<msc_cm_service_request:accepted>> | Accepted CM Service Request.</span><br><span> | paging_resp:rejected | <<msc_paging_resp:rejected>> | Rejected Paging Response.</span><br><span>diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h</span><br><span>index 60008b9..ca5c38a 100644</span><br><span>--- a/include/osmocom/msc/gsm_data.h</span><br><span>+++ b/include/osmocom/msc/gsm_data.h</span><br><span>@@ -65,12 +65,12 @@</span><br><span> };</span><br><span> </span><br><span> static const struct rate_ctr_desc msc_ctr_description[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-   [MSC_CTR_LOC_UPDATE_TYPE_ATTACH] =              {"loc_update_type:attach", "Received location update imsi attach requests."},</span><br><span style="color: hsl(0, 100%, 40%);">-       [MSC_CTR_LOC_UPDATE_TYPE_NORMAL] =              {"loc_update_type:normal", "Received location update normal requests."},</span><br><span style="color: hsl(0, 100%, 40%);">-    [MSC_CTR_LOC_UPDATE_TYPE_PERIODIC] =            {"loc_update_type:periodic", "Received location update periodic requests."},</span><br><span style="color: hsl(0, 100%, 40%);">-        [MSC_CTR_LOC_UPDATE_TYPE_DETACH] =              {"loc_update_type:detach", "Received location update detach indication."},</span><br><span style="color: hsl(0, 100%, 40%);">-  [MSC_CTR_LOC_UPDATE_FAILED] =           {"loc_update_resp:failed", "Rejected location updates."},</span><br><span style="color: hsl(0, 100%, 40%);">-   [MSC_CTR_LOC_UPDATE_COMPLETED] =        {"loc_update_resp:completed", "Successful location updates."},</span><br><span style="color: hsl(120, 100%, 40%);">+    [MSC_CTR_LOC_UPDATE_TYPE_ATTACH] =              {"loc_update_type:attach", "Received Location Update (IMSI Attach) requests."},</span><br><span style="color: hsl(120, 100%, 40%);">+   [MSC_CTR_LOC_UPDATE_TYPE_NORMAL] =              {"loc_update_type:normal", "Received Location Update (LAC change) requests."},</span><br><span style="color: hsl(120, 100%, 40%);">+    [MSC_CTR_LOC_UPDATE_TYPE_PERIODIC] =            {"loc_update_type:periodic", "Received (periodic) Location Update requests."},</span><br><span style="color: hsl(120, 100%, 40%);">+    [MSC_CTR_LOC_UPDATE_TYPE_DETACH] =              {"loc_update_type:detach", "Received IMSI Detach indications."},</span><br><span style="color: hsl(120, 100%, 40%);">+  [MSC_CTR_LOC_UPDATE_FAILED] =           {"loc_update_resp:failed", "Rejected Location Update requests."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_LOC_UPDATE_COMPLETED] =        {"loc_update_resp:completed", "Successful Location Update procedures."},</span><br><span>         [MSC_CTR_CM_SERVICE_REQUEST_REJECTED] = {"cm_service_request:rejected", "Rejected CM Service Request."},</span><br><span>         [MSC_CTR_CM_SERVICE_REQUEST_ACCEPTED] = {"cm_service_request:accepted", "Accepted CM Service Request."},</span><br><span>         [MSC_CTR_PAGING_RESP_REJECTED] =        {"paging_resp:rejected", "Rejected Paging Response."},</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/16385">change 16385</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/16385"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4f4a0d644db0a2dd7c8eefd846ea6913c0b780ce </div>
<div style="display:none"> Gerrit-Change-Number: 16385 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>