<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/16357">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc: fix potential NULL-pointer dereferences detected by GCC's LTO<br><br>Change-Id: Ib7ba8909dce64d1b8ff3a53495fe3eefc446ed8e<br>---<br>M src/libmsc/msc_ho.c<br>M src/libmsc/msc_vty.c<br>2 files changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c</span><br><span>index ac7602f..aa513eb 100644</span><br><span>--- a/src/libmsc/msc_ho.c</span><br><span>+++ b/src/libmsc/msc_ho.c</span><br><span>@@ -67,9 +67,12 @@</span><br><span> </span><br><span> void msc_ho_down_required_reject(struct msc_a *msc_a, enum gsm0808_cause cause)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       struct msc_i *msc_i = msc_a_msc_i(msc_a);</span><br><span style="color: hsl(120, 100%, 40%);">+     struct msc_i *msc_i;</span><br><span>         uint32_t event;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   msc_i = msc_a_msc_i(msc_a);</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_ASSERT(msc_i);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        struct ran_msg ran_enc_msg = {</span><br><span>               .msg_type = RAN_MSG_HANDOVER_REQUIRED_REJECT,</span><br><span>                .handover_required_reject = {</span><br><span>diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c</span><br><span>index f833585..cd82a07 100644</span><br><span>--- a/src/libmsc/msc_vty.c</span><br><span>+++ b/src/libmsc/msc_vty.c</span><br><span>@@ -1148,6 +1148,11 @@</span><br><span>  struct gsm_sms *sms;</span><br><span> </span><br><span>     sms = sms_from_text(receiver, sender_msisdn, 0, str);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!sms) {</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DLSMS, LOGL_ERROR, "Failed to allocate SMS\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  sms->protocol_id = tp_pid;</span><br><span> </span><br><span>    /* store in database for the queue */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/16357">change 16357</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/16357"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib7ba8909dce64d1b8ff3a53495fe3eefc446ed8e </div>
<div style="display:none"> Gerrit-Change-Number: 16357 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>