<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/16172">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">counters: clarify documentation for MSC_CTR_SMS_* entries<br><br>Please note that counter "sms:delivered" assumes "Delivered MT SMS",<br>but actually counts total number MT SMS delivery attempts. This<br>change describes its _actual_ (erroneous) behaviour.<br><br>Change-Id: I081cf962ce2658ceab02699f3cdee19658d00939<br>Related: OS#4273<br>---<br>M doc/manuals/chapters/counters_generated.adoc<br>M include/osmocom/msc/gsm_data.h<br>2 files changed, 14 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc</span><br><span>index e2587e8..526ed01 100644</span><br><span>--- a/doc/manuals/chapters/counters_generated.adoc</span><br><span>+++ b/doc/manuals/chapters/counters_generated.adoc</span><br><span>@@ -20,12 +20,12 @@</span><br><span> | cm_service_request:accepted | <<msc_cm_service_request:accepted>> | Accepted CM Service Request.</span><br><span> | paging_resp:rejected | <<msc_paging_resp:rejected>> | Rejected Paging Response.</span><br><span> | paging_resp:accepted | <<msc_paging_resp:accepted>> | Accepted Paging Response.</span><br><span style="color: hsl(0, 100%, 40%);">-| sms:submitted | <<msc_sms:submitted>> | Received a RPDU from a MS (MO).</span><br><span style="color: hsl(0, 100%, 40%);">-| sms:no_receiver | <<msc_sms:no_receiver>> | Counts SMS which couldn't routed because no receiver found.</span><br><span style="color: hsl(0, 100%, 40%);">-| sms:delivered | <<msc_sms:delivered>> | Global SMS Deliver attempts.</span><br><span style="color: hsl(0, 100%, 40%);">-| sms:rp_err_mem | <<msc_sms:rp_err_mem>> | CAUSE_MT_MEM_EXCEEDED errors of MS responses on a sms deliver attempt.</span><br><span style="color: hsl(0, 100%, 40%);">-| sms:rp_err_other | <<msc_sms:rp_err_other>> | Other error of MS responses on a sms delive attempt.</span><br><span style="color: hsl(0, 100%, 40%);">-| sms:deliver_unknown_error | <<msc_sms:deliver_unknown_error>> | Unknown error occurred during sms delivery.</span><br><span style="color: hsl(120, 100%, 40%);">+| sms:submitted | <<msc_sms:submitted>> | Total MO SMS received from the MS.</span><br><span style="color: hsl(120, 100%, 40%);">+| sms:no_receiver | <<msc_sms:no_receiver>> | Failed MO SMS delivery attempts (no receiver found).</span><br><span style="color: hsl(120, 100%, 40%);">+| sms:deliver_unknown_error | <<msc_sms:deliver_unknown_error>> | Failed MO SMS delivery attempts (other reason).</span><br><span style="color: hsl(120, 100%, 40%);">+| sms:delivered | <<msc_sms:delivered>> | Total MT SMS delivery attempts.</span><br><span style="color: hsl(120, 100%, 40%);">+| sms:rp_err_mem | <<msc_sms:rp_err_mem>> | Failed MT SMS delivery attempts (no memory).</span><br><span style="color: hsl(120, 100%, 40%);">+| sms:rp_err_other | <<msc_sms:rp_err_other>> | Failed MT SMS delivery attempts (other reason).</span><br><span> | call:mo_setup | <<msc_call:mo_setup>> | Received setup requests from a MS to init a MO call.</span><br><span> | call:mo_connect_ack | <<msc_call:mo_connect_ack>> | Received a connect ack from MS of a MO call. Call is now successful connected up.</span><br><span> | call:mt_setup | <<msc_call:mt_setup>> | Sent setup requests to the MS (MT).</span><br><span>diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h</span><br><span>index bcee213..60008b9 100644</span><br><span>--- a/include/osmocom/msc/gsm_data.h</span><br><span>+++ b/include/osmocom/msc/gsm_data.h</span><br><span>@@ -75,13 +75,14 @@</span><br><span> [MSC_CTR_CM_SERVICE_REQUEST_ACCEPTED] = {"cm_service_request:accepted", "Accepted CM Service Request."},</span><br><span> [MSC_CTR_PAGING_RESP_REJECTED] = {"paging_resp:rejected", "Rejected Paging Response."},</span><br><span> [MSC_CTR_PAGING_RESP_ACCEPTED] = {"paging_resp:accepted", "Accepted Paging Response."},</span><br><span style="color: hsl(0, 100%, 40%);">- [MSC_CTR_SMS_SUBMITTED] = {"sms:submitted", "Received a RPDU from a MS (MO)."},</span><br><span style="color: hsl(0, 100%, 40%);">- [MSC_CTR_SMS_NO_RECEIVER] = {"sms:no_receiver", "Counts SMS which couldn't routed because no receiver found."},</span><br><span style="color: hsl(0, 100%, 40%);">- [MSC_CTR_SMS_DELIVERED] = {"sms:delivered", "Global SMS Deliver attempts."},</span><br><span style="color: hsl(0, 100%, 40%);">- [MSC_CTR_SMS_RP_ERR_MEM] = {"sms:rp_err_mem", "CAUSE_MT_MEM_EXCEEDED errors of MS responses on a sms deliver attempt."},</span><br><span style="color: hsl(0, 100%, 40%);">- [MSC_CTR_SMS_RP_ERR_OTHER] = {"sms:rp_err_other", "Other error of MS responses on a sms delive attempt."},</span><br><span style="color: hsl(0, 100%, 40%);">- [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms:deliver_unknown_error", "Unknown error occurred during sms delivery."},</span><br><span style="color: hsl(0, 100%, 40%);">- /* FIXME: count also sms delivered */</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_SMS_SUBMITTED] = {"sms:submitted", "Total MO SMS received from the MS."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_SMS_NO_RECEIVER] = {"sms:no_receiver", "Failed MO SMS delivery attempts (no receiver found)."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms:deliver_unknown_error", "Failed MO SMS delivery attempts (other reason)."},</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: "sms:delivered" should actually count number of _successfully_ delivered MT SMS.</span><br><span style="color: hsl(120, 100%, 40%);">+ * The current description reflects its current (errorneous) behaviour. */</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_SMS_DELIVERED] = {"sms:delivered", "Total MT SMS delivery attempts."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_SMS_RP_ERR_MEM] = {"sms:rp_err_mem", "Failed MT SMS delivery attempts (no memory)."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_SMS_RP_ERR_OTHER] = {"sms:rp_err_other", "Failed MT SMS delivery attempts (other reason)."},</span><br><span> [MSC_CTR_CALL_MO_SETUP] = {"call:mo_setup", "Received setup requests from a MS to init a MO call."},</span><br><span> [MSC_CTR_CALL_MO_CONNECT_ACK] = {"call:mo_connect_ack", "Received a connect ack from MS of a MO call. Call is now successful connected up."},</span><br><span> [MSC_CTR_CALL_MT_SETUP] = {"call:mt_setup", "Sent setup requests to the MS (MT)."},</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/16172">change 16172</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/16172"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I081cf962ce2658ceab02699f3cdee19658d00939 </div>
<div style="display:none"> Gerrit-Change-Number: 16172 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>