<p>laforge would like tsaitgaist to <strong>review</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16421">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cardem: use simplest ATR as default ATR<br><br>This is the shortest and simplest ATR possible according to the<br>ISO 7816-3 spec.<br><br>It does not offer any non-default parameters (F, D, WI, ...)<br><br>Change-Id: I4ff41b5120bcadca652296f9d3691f7606be2bd2<br>---<br>M firmware/libcommon/source/card_emu.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/21/16421/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c</span><br><span>index 497b963..923226a 100644</span><br><span>--- a/firmware/libcommon/source/card_emu.c</span><br><span>+++ b/firmware/libcommon/source/card_emu.c</span><br><span>@@ -1151,8 +1151,8 @@</span><br><span>         }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* shortest ATR found in smartcard_list.txt */</span><br><span style="color: hsl(0, 100%, 40%);">-static const uint8_t default_atr[] = { 0x3B, 0x02, 0x14, 0x50 };</span><br><span style="color: hsl(120, 100%, 40%);">+/* shortest ATR possible (uses default speed and no options) */</span><br><span style="color: hsl(120, 100%, 40%);">+static const uint8_t default_atr[] = { 0x3B, 0x00 };</span><br><span> </span><br><span> static struct card_handle card_handles[NUM_SLOTS];</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16421">change 16421</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16421"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4ff41b5120bcadca652296f9d3691f7606be2bd2 </div>
<div style="display:none"> Gerrit-Change-Number: 16421 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: tsaitgaist <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>