<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/16386">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">counters: clarify documentation for MSC_CTR_CALL_* entries<br><br>Change-Id: Iad1ef917a229c3be51bd8fbe155f009f81e7d72a<br>---<br>M doc/manuals/chapters/counters_generated.adoc<br>M include/osmocom/msc/gsm_data.h<br>2 files changed, 14 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc</span><br><span>index 49f2589..d73803d 100644</span><br><span>--- a/doc/manuals/chapters/counters_generated.adoc</span><br><span>+++ b/doc/manuals/chapters/counters_generated.adoc</span><br><span>@@ -26,13 +26,13 @@</span><br><span> | sms:delivered | <<msc_sms:delivered>> | Total MT SMS delivery attempts.</span><br><span> | sms:rp_err_mem | <<msc_sms:rp_err_mem>> | Failed MT SMS delivery attempts (no memory).</span><br><span> | sms:rp_err_other | <<msc_sms:rp_err_other>> | Failed MT SMS delivery attempts (other reason).</span><br><span style="color: hsl(0, 100%, 40%);">-| call:mo_setup | <<msc_call:mo_setup>> | Received setup requests from a MS to init a MO call.</span><br><span style="color: hsl(0, 100%, 40%);">-| call:mo_connect_ack | <<msc_call:mo_connect_ack>> | Received a connect ack from MS of a MO call. Call is now successful connected up.</span><br><span style="color: hsl(0, 100%, 40%);">-| call:mt_setup | <<msc_call:mt_setup>> | Sent setup requests to the MS (MT).</span><br><span style="color: hsl(0, 100%, 40%);">-| call:mt_connect | <<msc_call:mt_connect>> | Sent a connect to the MS (MT).</span><br><span style="color: hsl(0, 100%, 40%);">-| call:active | <<msc_call:active>> | Count total amount of calls that ever reached active state.</span><br><span style="color: hsl(0, 100%, 40%);">-| call:complete | <<msc_call:complete>> | Count total amount of calls which got terminated by disconnect req or ind after reaching active state.</span><br><span style="color: hsl(0, 100%, 40%);">-| call:incomplete | <<msc_call:incomplete>> | Count total amount of call which got terminated by any other reason after reaching active state.</span><br><span style="color: hsl(120, 100%, 40%);">+| call:mo_setup | <<msc_call:mo_setup>> | Received MO SETUP messages (MO call establishment).</span><br><span style="color: hsl(120, 100%, 40%);">+| call:mo_connect_ack | <<msc_call:mo_connect_ack>> | Received MO CONNECT messages (MO call establishment).</span><br><span style="color: hsl(120, 100%, 40%);">+| call:mt_setup | <<msc_call:mt_setup>> | Sent MT SETUP messages (MT call establishment).</span><br><span style="color: hsl(120, 100%, 40%);">+| call:mt_connect | <<msc_call:mt_connect>> | Sent MT CONNECT messages (MT call establishment).</span><br><span style="color: hsl(120, 100%, 40%);">+| call:active | <<msc_call:active>> | Calls that ever reached the active state.</span><br><span style="color: hsl(120, 100%, 40%);">+| call:complete | <<msc_call:complete>> | Calls terminated by DISCONNECT message after reaching the active state.</span><br><span style="color: hsl(120, 100%, 40%);">+| call:incomplete | <<msc_call:incomplete>> | Calls terminated by any other reason after reaching the active state.</span><br><span> | nc_ss:mo_requests | <<msc_nc_ss:mo_requests>> | Received MS-initiated call independent SS/USSD requests.</span><br><span> | nc_ss:mo_established | <<msc_nc_ss:mo_established>> | Established MS-initiated call independent SS/USSD sessions.</span><br><span> | nc_ss:mt_requests | <<msc_nc_ss:mt_requests>> | Received network-initiated call independent SS/USSD requests.</span><br><span>diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h</span><br><span>index ca5c38a..87629ad 100644</span><br><span>--- a/include/osmocom/msc/gsm_data.h</span><br><span>+++ b/include/osmocom/msc/gsm_data.h</span><br><span>@@ -83,13 +83,13 @@</span><br><span>       [MSC_CTR_SMS_DELIVERED] =               {"sms:delivered", "Total MT SMS delivery attempts."},</span><br><span>    [MSC_CTR_SMS_RP_ERR_MEM] =              {"sms:rp_err_mem", "Failed MT SMS delivery attempts (no memory)."},</span><br><span>      [MSC_CTR_SMS_RP_ERR_OTHER] =            {"sms:rp_err_other", "Failed MT SMS delivery attempts (other reason)."},</span><br><span style="color: hsl(0, 100%, 40%);">-    [MSC_CTR_CALL_MO_SETUP] =               {"call:mo_setup", "Received setup requests from a MS to init a MO call."},</span><br><span style="color: hsl(0, 100%, 40%);">-  [MSC_CTR_CALL_MO_CONNECT_ACK] =                 {"call:mo_connect_ack", "Received a connect ack from MS of a MO call. Call is now successful connected up."},</span><br><span style="color: hsl(0, 100%, 40%);">-       [MSC_CTR_CALL_MT_SETUP] =               {"call:mt_setup", "Sent setup requests to the MS (MT)."},</span><br><span style="color: hsl(0, 100%, 40%);">-   [MSC_CTR_CALL_MT_CONNECT] =             {"call:mt_connect", "Sent a connect to the MS (MT)."},</span><br><span style="color: hsl(0, 100%, 40%);">-      [MSC_CTR_CALL_ACTIVE] =                 {"call:active", "Count total amount of calls that ever reached active state."},</span><br><span style="color: hsl(0, 100%, 40%);">-     [MSC_CTR_CALL_COMPLETE] =               {"call:complete", "Count total amount of calls which got terminated by disconnect req or ind after reaching active state."},</span><br><span style="color: hsl(0, 100%, 40%);">-        [MSC_CTR_CALL_INCOMPLETE] =             {"call:incomplete", "Count total amount of call which got terminated by any other reason after reaching active state."},</span><br><span style="color: hsl(120, 100%, 40%);">+  [MSC_CTR_CALL_MO_SETUP] =               {"call:mo_setup", "Received MO SETUP messages (MO call establishment)."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_CALL_MO_CONNECT_ACK] =         {"call:mo_connect_ack", "Received MO CONNECT messages (MO call establishment)."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_CALL_MT_SETUP] =               {"call:mt_setup", "Sent MT SETUP messages (MT call establishment)."},</span><br><span style="color: hsl(120, 100%, 40%);">+     [MSC_CTR_CALL_MT_CONNECT] =             {"call:mt_connect", "Sent MT CONNECT messages (MT call establishment)."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [MSC_CTR_CALL_ACTIVE] =                 {"call:active", "Calls that ever reached the active state."},</span><br><span style="color: hsl(120, 100%, 40%);">+     [MSC_CTR_CALL_COMPLETE] =               {"call:complete", "Calls terminated by DISCONNECT message after reaching the active state."},</span><br><span style="color: hsl(120, 100%, 40%);">+     [MSC_CTR_CALL_INCOMPLETE] =             {"call:incomplete", "Calls terminated by any other reason after reaching the active state."},</span><br><span>    [MSC_CTR_NC_SS_MO_REQUESTS] =           {"nc_ss:mo_requests", "Received MS-initiated call independent SS/USSD requests."},</span><br><span>       [MSC_CTR_NC_SS_MO_ESTABLISHED] =        {"nc_ss:mo_established", "Established MS-initiated call independent SS/USSD sessions."},</span><br><span>         [MSC_CTR_NC_SS_MT_REQUESTS] =           {"nc_ss:mt_requests", "Received network-initiated call independent SS/USSD requests."},</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/16386">change 16386</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/16386"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iad1ef917a229c3be51bd8fbe155f009f81e7d72a </div>
<div style="display:none"> Gerrit-Change-Number: 16386 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>