<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16367">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Check for osmo_fsm_register() error return value<br><br>Change-Id: Idbc1557739b2a253b73914e6f1f18a6d169d882e<br>---<br>M tests/fsm/fsm_dealloc_test.c<br>M tests/fsm/fsm_test.c<br>M tests/tdef/tdef_test.c<br>M tests/use_count/use_count_test.c<br>4 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/16367/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/fsm/fsm_dealloc_test.c b/tests/fsm/fsm_dealloc_test.c</span><br><span>index 9a6974d..48f80e5 100644</span><br><span>--- a/tests/fsm/fsm_dealloc_test.c</span><br><span>+++ b/tests/fsm/fsm_dealloc_test.c</span><br><span>@@ -452,7 +452,7 @@</span><br><span> </span><br><span>        log_set_category_filter(osmo_stderr_target, DLGLOBAL, 1, LOGL_DEBUG);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       osmo_fsm_register(&test_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(osmo_fsm_register(&test_fsm) == 0);</span><br><span> </span><br><span>      test_osmo_fsm_term_safely();</span><br><span>         test_osmo_fsm_set_dealloc_ctx();</span><br><span>diff --git a/tests/fsm/fsm_test.c b/tests/fsm/fsm_test.c</span><br><span>index f8ebdc7..911aad8 100644</span><br><span>--- a/tests/fsm/fsm_test.c</span><br><span>+++ b/tests/fsm/fsm_test.c</span><br><span>@@ -417,7 +417,7 @@</span><br><span> </span><br><span>      g_ctx = NULL;</span><br><span>        OSMO_ASSERT(osmo_fsm_find_by_name(fsm.name) == NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-   osmo_fsm_register(&fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+  OSMO_ASSERT(osmo_fsm_register(&fsm) == 0);</span><br><span>       OSMO_ASSERT(osmo_fsm_find_by_name(fsm.name) == &fsm);</span><br><span> </span><br><span>        OSMO_ASSERT(osmo_fsm_inst_find_by_name(&fsm, "my_id") == NULL);</span><br><span>diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c</span><br><span>index 276330a..9c0808e 100644</span><br><span>--- a/tests/tdef/tdef_test.c</span><br><span>+++ b/tests/tdef/tdef_test.c</span><br><span>@@ -475,7 +475,7 @@</span><br><span>     log_set_print_category(osmo_stderr_target, 1);</span><br><span>       log_set_use_color(osmo_stderr_target, 0);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   osmo_fsm_register(&test_tdef_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_ASSERT(osmo_fsm_register(&test_tdef_fsm) == 0);</span><br><span> </span><br><span>         test_tdef_get(argc > 1);</span><br><span>  test_tdef_get_nonexisting();</span><br><span>diff --git a/tests/use_count/use_count_test.c b/tests/use_count/use_count_test.c</span><br><span>index 0b081c9..95af308 100644</span><br><span>--- a/tests/use_count/use_count_test.c</span><br><span>+++ b/tests/use_count/use_count_test.c</span><br><span>@@ -331,7 +331,7 @@</span><br><span>      log_set_print_level(osmo_stderr_target, 1);</span><br><span>  log_set_use_color(osmo_stderr_target, 0);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   osmo_fsm_register(&foo_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(osmo_fsm_register(&foo_fsm) == 0);</span><br><span> </span><br><span>       test_use_count_fsm();</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16367">change 16367</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16367"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idbc1557739b2a253b73914e6f1f18a6d169d882e </div>
<div style="display:none"> Gerrit-Change-Number: 16367 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>