<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16359">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">check for osmo_fsm_register() error return value<br><br>Change-Id: I77e8ace007a3d6b9c40d3e158d1cdb7576aab77b<br>---<br>M src/osmo-bsc/a_reset.c<br>M src/osmo-bsc/abis_om2000.c<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/a_reset.c b/src/osmo-bsc/a_reset.c</span><br><span>index 9e046be..bc41914 100644</span><br><span>--- a/src/osmo-bsc/a_reset.c</span><br><span>+++ b/src/osmo-bsc/a_reset.c</span><br><span>@@ -151,7 +151,7 @@</span><br><span> </span><br><span>      /* Register the fsm description (if not already done) */</span><br><span>     if (osmo_fsm_find_by_name(fsm.name) != &fsm)</span><br><span style="color: hsl(0, 100%, 40%);">-                osmo_fsm_register(&fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+          OSMO_ASSERT(osmo_fsm_register(&fsm) == 0);</span><br><span> </span><br><span>   /* Allocate and configure a new fsm instance */</span><br><span>      reset_ctx = talloc_zero(msc, struct reset_ctx);</span><br><span>diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c</span><br><span>index e6b06c3..14c373b 100644</span><br><span>--- a/src/osmo-bsc/abis_om2000.c</span><br><span>+++ b/src/osmo-bsc/abis_om2000.c</span><br><span>@@ -2764,7 +2764,7 @@</span><br><span> </span><br><span> static __attribute__((constructor)) void abis_om2k_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  osmo_fsm_register(&om2k_mo_fsm);</span><br><span style="color: hsl(0, 100%, 40%);">-    osmo_fsm_register(&om2k_bts_fsm);</span><br><span style="color: hsl(0, 100%, 40%);">-   osmo_fsm_register(&om2k_trx_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(osmo_fsm_register(&om2k_mo_fsm) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_ASSERT(osmo_fsm_register(&om2k_bts_fsm) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+       OSMO_ASSERT(osmo_fsm_register(&om2k_trx_fsm) == 0);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16359">change 16359</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/16359"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I77e8ace007a3d6b9c40d3e158d1cdb7576aab77b </div>
<div style="display:none"> Gerrit-Change-Number: 16359 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>