<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/16353">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsnemu: Fix null-pointer format string argument<br><br>Modern gcc-9.2.1 actually fails like this with --enable-werror active:<br><br>In file included from sgsnemu.c:52:<br>In function ‘process_options’,<br> inlined from ‘main’ at sgsnemu.c:1557:6:<br>../lib/syserr.h:31:3: error: ‘%s’ directive argument is null [-Werror=format-overflow=]<br> 31 | logp2(sub, pri, __FILE__, __LINE__, 0, \<br> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br> 32 | fmt "\n", ##args); \<br> | ~~~~~~~~~~~~~~~~~<br>sgsnemu.c:435:3: note: in expansion of macro ‘SYS_ERR’<br> 435 | SYS_ERR(DSGSN, LOGL_ERROR, 0,<br> | ^~~~~~~<br>sgsnemu.c: In function ‘main’:<br>sgsnemu.c:436:42: note: format string is defined here<br> 436 | "Listening address must be specified: %s!",<br> | ^~<br><br>It is correct: We are dereferencing args_info.listen_addr in a<br>branch which explicitly checks if that is NULL beforehand :/<br><br>Change-Id: I417f447f821d396aa92049e0a791121240f1cf44<br>---<br>M sgsnemu/sgsnemu.c<br>1 file changed, 1 insertion(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c</span><br><span>index 863ea51..7904c49 100644</span><br><span>--- a/sgsnemu/sgsnemu.c</span><br><span>+++ b/sgsnemu/sgsnemu.c</span><br><span>@@ -433,8 +433,7 @@</span><br><span> }</span><br><span> } else {</span><br><span> SYS_ERR(DSGSN, LOGL_ERROR, 0,</span><br><span style="color: hsl(0, 100%, 40%);">- "Listening address must be specified: %s!",</span><br><span style="color: hsl(0, 100%, 40%);">- args_info.listen_arg);</span><br><span style="color: hsl(120, 100%, 40%);">+ "Listening address must be specified!");</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/16353">change 16353</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/16353"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I417f447f821d396aa92049e0a791121240f1cf44 </div>
<div style="display:none"> Gerrit-Change-Number: 16353 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>