<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16368">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns_instantiate(): propagate errors from gprs_sns_init() to caller<br><br>Change-Id: I71f347a2f0376716e5f83d33a7931eb8a99aad77<br>---<br>M src/gb/gprs_ns.c<br>1 file changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c</span><br><span>index c77ebb3..ac39e4a 100644</span><br><span>--- a/src/gb/gprs_ns.c</span><br><span>+++ b/src/gb/gprs_ns.c</span><br><span>@@ -1884,13 +1884,18 @@</span><br><span>  */</span><br><span> struct gprs_ns_inst *gprs_ns_instantiate(gprs_ns_cb_t *cb, void *ctx)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   struct gprs_ns_inst *nsi = talloc_zero(ctx, struct gprs_ns_inst);</span><br><span style="color: hsl(120, 100%, 40%);">+     struct gprs_ns_inst *nsi;</span><br><span> </span><br><span>        if (!gprs_sns_fsm_registered) {</span><br><span style="color: hsl(0, 100%, 40%);">-         gprs_sns_init();</span><br><span style="color: hsl(120, 100%, 40%);">+              int rc = gprs_sns_init();</span><br><span style="color: hsl(120, 100%, 40%);">+             if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                        return NULL;</span><br><span>                 gprs_sns_fsm_registered = true;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ nsi = talloc_zero(ctx, struct gprs_ns_inst);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!nsi)</span><br><span style="color: hsl(120, 100%, 40%);">+             return NULL;</span><br><span>         nsi->cb = cb;</span><br><span>     INIT_LLIST_HEAD(&nsi->gprs_nsvcs);</span><br><span>    nsi->timeout[NS_TOUT_TNS_BLOCK] = 3;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16368">change 16368</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16368"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I71f347a2f0376716e5f83d33a7931eb8a99aad77 </div>
<div style="display:none"> Gerrit-Change-Number: 16368 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>