<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16352">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TEI_DN<br><br>When running a multi-trx setup, upon stopping osmo-bts one can see:<br><br>DCHAN ERROR lchan_fsm.c:80 lchan(0-1-7-TCH_F-0)[0x612000010120]{UNUSED}:<br>            (type=NONE) lchan allocation failed in state UNUSED: LCHAN_EV_TS_ERROR<br>DCHAN ERROR lchan_fsm.c:144 lchan(0-1-7-TCH_F-0)[0x612000010120]{UNUSED}:<br>            (type=NONE) lchan activation failed<br>            (lchan allocation failed in state UNUSED: LCHAN_EV_TS_ERROR)<br><br>These messages appear only for trx->nr > 0, and the problem is in<br>inp_sig_cb(): when the main OML link goes down, we should notify<br>all timeslots *of all TRXes*, not only TRX0.<br><br>FIXME: how can we distinguish the main OML link from per-TRX ones?<br><br>Change-Id: I3dc657ac5a2c5334747bd4f4db1a658acb323942<br>---<br>M src/osmo-bsc/osmo_bsc_main.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/16352/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index da2914d..5c65c4c 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -333,6 +333,7 @@</span><br><span> {</span><br><span>     struct input_signal_data *isd = signal_data;</span><br><span>         struct gsm_bts_trx *trx = isd->trx;</span><br><span style="color: hsl(120, 100%, 40%);">+        struct gsm_bts_trx *cur_trx;</span><br><span>         /* N. B: we rely on attribute order when parsing response in abis_nm_rx_get_attr_resp() */</span><br><span>   const uint8_t bts_attr[] = { NM_ATT_MANUF_ID, NM_ATT_SW_CONFIG, };</span><br><span>   const uint8_t trx_attr[] = { NM_ATT_MANUF_STATE, NM_ATT_SW_CONFIG, };</span><br><span>@@ -351,7 +352,6 @@</span><br><span>          if (isd->link_type == E1INP_SIGN_OML) {</span><br><span>                   /* TODO: this is required for the Nokia BTS, hopping is configured</span><br><span>                      during OML, other MA is not set.  */</span><br><span style="color: hsl(0, 100%, 40%);">-                 struct gsm_bts_trx *cur_trx;</span><br><span>                         /* was static in system_information.c */</span><br><span>                     extern int generate_cell_chan_list(uint8_t *chan_list, struct gsm_bts *bts);</span><br><span>                         uint8_t ca[20];</span><br><span>@@ -379,7 +379,10 @@</span><br><span> </span><br><span>           if (isd->link_type == E1INP_SIGN_OML) {</span><br><span>                   rate_ctr_inc(&trx->bts->bts_ctrs->ctr[BTS_CTR_BTS_OML_FAIL]);</span><br><span style="color: hsl(0, 100%, 40%);">-                      all_ts_dispatch_event(trx, TS_EV_OML_DOWN);</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* Notify all timeslots of all TRXes that the OML link is gone.</span><br><span style="color: hsl(120, 100%, 40%);">+                        * FIXME: what about per-TRX OML links? */</span><br><span style="color: hsl(120, 100%, 40%);">+                    llist_for_each_entry(cur_trx, &trx->bts->trx_list, list)</span><br><span style="color: hsl(120, 100%, 40%);">+                            all_ts_dispatch_event(cur_trx, TS_EV_OML_DOWN);</span><br><span>              } else if (isd->link_type == E1INP_SIGN_RSL) {</span><br><span>                    rate_ctr_inc(&trx->bts->bts_ctrs->ctr[BTS_CTR_BTS_RSL_FAIL]);</span><br><span>                   acc_ramp_abort(&trx->bts->acc_ramp);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16352">change 16352</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/16352"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3dc657ac5a2c5334747bd4f4db1a658acb323942 </div>
<div style="display:none"> Gerrit-Change-Number: 16352 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>