<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16345">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">VTY: add warning about changing PCU socket path at run-time<br><br>Change-Id: I7cee2d782bd3dfc2cc8d2febc16dca905dcc294e<br>---<br>M src/pcu_vty.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_vty.c b/src/pcu_vty.c</span><br><span>index 2fd57d0..1f46707 100644</span><br><span>--- a/src/pcu_vty.c</span><br><span>+++ b/src/pcu_vty.c</span><br><span>@@ -1097,12 +1097,13 @@</span><br><span> {</span><br><span>  struct gprs_rlcmac_bts *bts = bts_main_data();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    if (vty->type != VTY_FILE)</span><br><span style="color: hsl(120, 100%, 40%);">+         vty_out(vty, "Changing PCU socket path at run-time has no effect%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       if (bts->pcu_sock_path) {</span><br><span style="color: hsl(0, 100%, 40%);">-            /* FIXME: close the interface? */</span><br><span>            talloc_free(bts->pcu_sock_path);</span><br><span>  }</span><br><span>    bts->pcu_sock_path = talloc_strdup(tall_pcu_ctx, argv[0]);</span><br><span style="color: hsl(0, 100%, 40%);">-   /* FIXME: re-open the interface? */</span><br><span> </span><br><span>      return CMD_SUCCESS;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16345">change 16345</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/16345"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7cee2d782bd3dfc2cc8d2febc16dca905dcc294e </div>
<div style="display:none"> Gerrit-Change-Number: 16345 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>