<p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/include/osmocom/mslookup/mdns.h">File include/osmocom/mslookup/mdns.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/include/osmocom/mslookup/mdns.h@15">Patch Set #7, Line 15:</a> <code style="font-family:monospace,monospace"> * You should have received a copy of the GNU Affero General Public License</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">See my license comment on the other patch</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns.c">File src/mslookup/mdns.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns.c@117">Patch Set #7, Line 117:</a> <code style="font-family:monospace,monospace">           case OSMO_MDNS_RFC_RECORD_TYPE_A:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Typically no indent of case in switch, but not critical</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns_msg.c">File src/mslookup/mdns_msg.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns_msg.c@67">Patch Set #7, Line 67:</a> <code style="font-family:monospace,monospace">     ret = talloc(ctx, struct osmo_mdns_msg_request);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We rarely ose talloc without _zero as a safeguard. What if somebody adds some fields in the future ?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256">change 16256</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16256"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I03a0ffa1d4dc1b24ac78a5ad0975bca90a49c728 </div>
<div style="display:none"> Gerrit-Change-Number: 16256 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 30 Nov 2019 09:51:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>