<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/13624">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">LLC: Don't use hard-coded N201-U / N201-I values in XID<br><br>The N201 values are negotiated per SAPI, and there are default values<br>per each SAPI.  Let's use those rather than hard-coded values.<br><br>Closes: OS#3954<br>Change-Id: I447a3c6dd85311772a6e219c62dc820d2726857f<br>---<br>M src/sgsn/gprs_llc.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_llc.c b/src/sgsn/gprs_llc.c</span><br><span>index ed5d55e..6e22e65 100644</span><br><span>--- a/src/sgsn/gprs_llc.c</span><br><span>+++ b/src/sgsn/gprs_llc.c</span><br><span>@@ -69,17 +69,20 @@</span><br><span>       struct gprs_llc_xid_field xid_version;</span><br><span>       struct gprs_llc_xid_field xid_n201u;</span><br><span>         struct gprs_llc_xid_field xid_n201i;</span><br><span style="color: hsl(120, 100%, 40%);">+  uint16_t n201_u, n201_i;</span><br><span> </span><br><span>         xid_version.type = GPRS_LLC_XID_T_VERSION;</span><br><span>   xid_version.data = (uint8_t *) "\x00";</span><br><span>     xid_version.data_len = 1;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ n201_u = htons(lle->params.n201_u);</span><br><span>       xid_n201u.type = GPRS_LLC_XID_T_N201_U;</span><br><span style="color: hsl(0, 100%, 40%);">- xid_n201u.data = (uint8_t *) "\x05\xf0";</span><br><span style="color: hsl(120, 100%, 40%);">+    xid_n201u.data = (uint8_t *) &n201_u;</span><br><span>    xid_n201u.data_len = 2;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   n201_i = htons(lle->params.n201_i);</span><br><span>       xid_n201i.type = GPRS_LLC_XID_T_N201_I;</span><br><span style="color: hsl(0, 100%, 40%);">- xid_n201i.data = (uint8_t *) "\x05\xf0";</span><br><span style="color: hsl(120, 100%, 40%);">+    xid_n201i.data = (uint8_t *) &n201_i;</span><br><span>    xid_n201i.data_len = 2;</span><br><span> </span><br><span>  /* Add locally managed XID Fields */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/13624">change 13624</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/13624"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I447a3c6dd85311772a6e219c62dc820d2726857f </div>
<div style="display:none"> Gerrit-Change-Number: 13624 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>