<p style="white-space: pre-wrap; word-wrap: break-word;">Fine in general, just a few cosmetic comments.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn">File pcu/PCU_Tests_RAW.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1120">Patch Set #2, Line 1120:</a> <code style="font-family:monospace,monospace">lqual_cb := 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No need to initialize it here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1172">Patch Set #2, Line 1172:</a> <code style="font-family:monospace,monospace">match</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can we just compare them like: last_ch_coding == CH_CODING_CS3?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1197">Patch Set #2, Line 1197:</a> <code style="font-family:monospace,monospace">match</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can we just compare them like: last_ch_coding == CH_CODING_CS1?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1236">Patch Set #2, Line 1236:</a> <code style="font-family:monospace,monospace">15</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Cosmetic: actually, 16 (I also made this mistake in TC_cs_lqual_ul_tbf).</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337/2/pcu/PCU_Tests_RAW.ttcn@1258">Patch Set #2, Line 1258:</a> <code style="font-family:monospace,monospace">match</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same here</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337">change 16337</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3aa654e6f678698e5b8cb4914f1ca5b39fc08568 </div>
<div style="display:none"> Gerrit-Change-Number: 16337 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 29 Nov 2019 17:17:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>