<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/16298">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix incoming call while Paging<br><br>Do not free the CC transaction when an MT subscriber is already being Paged.<br>Instead, invoke another paging request, which paging.c will correctly add to<br>the list of pending paging response callbacks to run.<br><br>A ttcn3 test is linked in the related patch (s.b.).<br><br>Related: OS#4240<br>Related: Ieeae6322d4e80893ea3408c6b74bf8e32bea8e46<br>Change-Id: Idd4537b5f4817d17e5c87d9a93775a32aee0e7be<br>---<br>M src/libmsc/gsm_04_08_cc.c<br>1 file changed, 2 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c</span><br><span>index 4e604e5..8cfb611 100644</span><br><span>--- a/src/libmsc/gsm_04_08_cc.c</span><br><span>+++ b/src/libmsc/gsm_04_08_cc.c</span><br><span>@@ -1935,19 +1935,11 @@</span><br><span> * log it now. */</span><br><span> LOG_TRANS_CAT(trans, DMNCC, LOGL_DEBUG, "rx %s\n", get_mncc_name(msg->msg_type));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (vsub->cs.is_paging) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOG_TRANS(trans, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">- "rx %s, subscriber not yet connected, paging already started\n",</span><br><span style="color: hsl(0, 100%, 40%);">- get_mncc_name(msg->msg_type));</span><br><span style="color: hsl(0, 100%, 40%);">- vlr_subscr_put(vsub, __func__);</span><br><span style="color: hsl(0, 100%, 40%);">- trans_free(trans);</span><br><span style="color: hsl(0, 100%, 40%);">- return 0;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* store setup information until paging succeeds */</span><br><span> memcpy(&trans->cc.msg, data, sizeof(struct gsm_mncc));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Request a channel */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Request a channel. If Paging already started, paging_request_start() will append the new</span><br><span style="color: hsl(120, 100%, 40%);">+ * trans to the already ongoing Paging. */</span><br><span> trans->paging_request = paging_request_start(vsub, PAGING_CAUSE_CALL_CONVERSATIONAL,</span><br><span> cc_paging_cb, trans, "MNCC: establish call");</span><br><span> if (!trans->paging_request) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/16298">change 16298</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/16298"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idd4537b5f4817d17e5c87d9a93775a32aee0e7be </div>
<div style="display:none"> Gerrit-Change-Number: 16298 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>