<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/16303">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc_a CC: add some basic sanity tests<br><br>Change-Id: I9d7d7d4073282abc6c02a6a297c807dc70c5154c<br>---<br>M src/libmsc/msc_a.c<br>1 file changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/03/16303/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c</span><br><span>index a4048f4..bc5b7ea 100644</span><br><span>--- a/src/libmsc/msc_a.c</span><br><span>+++ b/src/libmsc/msc_a.c</span><br><span>@@ -518,6 +518,12 @@</span><br><span>      struct gsm_trans *cc_trans = msc_a->cc.active_trans;</span><br><span>      struct gsm0808_channel_type channel_type;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (!cc_trans) {</span><br><span style="color: hsl(120, 100%, 40%);">+              LOG_MSC_A(msc_a, LOGL_ERROR, "No CC transaction active\n");</span><br><span style="color: hsl(120, 100%, 40%);">+         call_leg_release(msc_a->cc.call_leg);</span><br><span style="color: hsl(120, 100%, 40%);">+              return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* Once a CI is known, we could also CRCX the CN side of the MGW endpoint, but it makes sense to wait for the</span><br><span>         * codec to be determined by the Assignment Complete message, first. */</span><br><span> </span><br><span>@@ -627,6 +633,10 @@</span><br><span>                   LOG_MSC_A(msc_a, LOGL_ERROR, "Invalid data for %s\n", osmo_fsm_event_name(fi->fsm, event));</span><br><span>                     return;</span><br><span>              }</span><br><span style="color: hsl(120, 100%, 40%);">+             if (!msc_a->cc.call_leg) {</span><br><span style="color: hsl(120, 100%, 40%);">+                 LOG_MSC_A(msc_a, LOGL_ERROR, "No call leg active\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                       return;</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span>            if (!osmo_sockaddr_str_is_nonzero(&rtps->local)) {</span><br><span>                    LOG_MSC_A(msc_a, LOGL_ERROR, "Invalid RTP address received from MGW: " OSMO_SOCKADDR_STR_FMT "\n",</span><br><span>                                OSMO_SOCKADDR_STR_FMT_ARGS(&rtps->local));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/16303">change 16303</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/16303"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9d7d7d4073282abc6c02a6a297c807dc70c5154c </div>
<div style="display:none"> Gerrit-Change-Number: 16303 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>