<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/15949">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc_vlr_tests: better err logging for dtap msgs<br><br>Change-Id: I3edd90be40555dd648e9f16db5b6040665a19a95<br>---<br>M tests/msc_vlr/msc_vlr_tests.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c</span><br><span>index de4913a..e00c337 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_tests.c</span><br><span>+++ b/tests/msc_vlr/msc_vlr_tests.c</span><br><span>@@ -254,8 +254,10 @@</span><br><span> </span><br><span>   /* Mask the sequence number out before comparing */</span><br><span>  msg->data[1] &= 0x3f;</span><br><span style="color: hsl(0, 100%, 40%);">-    if (!msgb_eq_data_print(msg, dtap_tx_expected->data, dtap_tx_expected->len))</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!msgb_eq_data_print(msg, dtap_tx_expected->data, dtap_tx_expected->len)) {</span><br><span style="color: hsl(120, 100%, 40%);">+          btw("Expected %s", osmo_hexdump(dtap_tx_expected->data, dtap_tx_expected->len));</span><br><span>             abort();</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span> </span><br><span>        btw("DTAP matches expected message");</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/15949">change 15949</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/15949"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3edd90be40555dd648e9f16db5b6040665a19a95 </div>
<div style="display:none"> Gerrit-Change-Number: 15949 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>