<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16265">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sercom config for t1<br><br>T0 doesn't work, as the datasheet states it's synchronous, apparently to the internal clock.<br>That doesn't align too well with what 7816-3 says, so this already fails during the ATR after a few tries.<br><br>Change-Id: Ie6cb7ec51036f1de15c83b59d130f3cb85309594<br>---<br>M sysmoOCTSIM/config/hpl_sercom_config.h<br>1 file changed, 14 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sysmoOCTSIM/config/hpl_sercom_config.h b/sysmoOCTSIM/config/hpl_sercom_config.h</span><br><span>index beac040..bb2bbff 100644</span><br><span>--- a/sysmoOCTSIM/config/hpl_sercom_config.h</span><br><span>+++ b/sysmoOCTSIM/config/hpl_sercom_config.h</span><br><span>@@ -52,7 +52,7 @@</span><br><span> // <i> Number of stop bits in USART frame</span><br><span> // <id> usart_stop_bit</span><br><span> #ifndef CONF_SERCOM_0_USART_SBMODE</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_0_USART_SBMODE 0</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_0_USART_SBMODE 1</span><br><span> #endif</span><br><span> </span><br><span> // <o> Baud rate <1-3000000></span><br><span>@@ -70,7 +70,7 @@</span><br><span> // <i> Define ISO7816 protocol type as 0.</span><br><span> // <id> usart_iso7816_type</span><br><span> #ifndef CONF_SERCOM_0_USART_ISO7816_PROTOCOL_T</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_0_USART_ISO7816_PROTOCOL_T 0x1</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_0_USART_ISO7816_PROTOCOL_T 0x0</span><br><span> #endif</span><br><span> </span><br><span> // <o> ISO7816 Inhibit Not Acknowledge</span><br><span>@@ -324,7 +324,7 @@</span><br><span> // <i> Number of stop bits in USART frame</span><br><span> // <id> usart_stop_bit</span><br><span> #ifndef CONF_SERCOM_1_USART_SBMODE</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_1_USART_SBMODE 0</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_1_USART_SBMODE 1</span><br><span> #endif</span><br><span> </span><br><span> // <o> Baud rate <1-3000000></span><br><span>@@ -342,7 +342,7 @@</span><br><span> // <i> Define ISO7816 protocol type as 0.</span><br><span> // <id> usart_iso7816_type</span><br><span> #ifndef CONF_SERCOM_1_USART_ISO7816_PROTOCOL_T</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_1_USART_ISO7816_PROTOCOL_T 0x1</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_1_USART_ISO7816_PROTOCOL_T 0x0</span><br><span> #endif</span><br><span> </span><br><span> // <o> ISO7816 Inhibit Not Acknowledge</span><br><span>@@ -596,7 +596,7 @@</span><br><span> // <i> Number of stop bits in USART frame</span><br><span> // <id> usart_stop_bit</span><br><span> #ifndef CONF_SERCOM_2_USART_SBMODE</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_2_USART_SBMODE 0</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_2_USART_SBMODE 1</span><br><span> #endif</span><br><span> </span><br><span> // <o> Baud rate <1-3000000></span><br><span>@@ -614,7 +614,7 @@</span><br><span> // <i> Define ISO7816 protocol type as 0.</span><br><span> // <id> usart_iso7816_type</span><br><span> #ifndef CONF_SERCOM_2_USART_ISO7816_PROTOCOL_T</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_2_USART_ISO7816_PROTOCOL_T 0x1</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_2_USART_ISO7816_PROTOCOL_T 0x0</span><br><span> #endif</span><br><span> </span><br><span> // <o> ISO7816 Inhibit Not Acknowledge</span><br><span>@@ -868,7 +868,7 @@</span><br><span> // <i> Number of stop bits in USART frame</span><br><span> // <id> usart_stop_bit</span><br><span> #ifndef CONF_SERCOM_3_USART_SBMODE</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_3_USART_SBMODE 0</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_3_USART_SBMODE 1</span><br><span> #endif</span><br><span> </span><br><span> // <o> Baud rate <1-3000000></span><br><span>@@ -886,7 +886,7 @@</span><br><span> // <i> Define ISO7816 protocol type as 0.</span><br><span> // <id> usart_iso7816_type</span><br><span> #ifndef CONF_SERCOM_3_USART_ISO7816_PROTOCOL_T</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_3_USART_ISO7816_PROTOCOL_T 0x1</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_3_USART_ISO7816_PROTOCOL_T 0x0</span><br><span> #endif</span><br><span> </span><br><span> // <o> ISO7816 Inhibit Not Acknowledge</span><br><span>@@ -1140,7 +1140,7 @@</span><br><span> // <i> Number of stop bits in USART frame</span><br><span> // <id> usart_stop_bit</span><br><span> #ifndef CONF_SERCOM_4_USART_SBMODE</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_4_USART_SBMODE 0</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_4_USART_SBMODE 1</span><br><span> #endif</span><br><span> </span><br><span> // <o> Baud rate <1-3000000></span><br><span>@@ -1158,7 +1158,7 @@</span><br><span> // <i> Define ISO7816 protocol type as 0.</span><br><span> // <id> usart_iso7816_type</span><br><span> #ifndef CONF_SERCOM_4_USART_ISO7816_PROTOCOL_T</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_4_USART_ISO7816_PROTOCOL_T 0x1</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_4_USART_ISO7816_PROTOCOL_T 0x0</span><br><span> #endif</span><br><span> </span><br><span> // <o> ISO7816 Inhibit Not Acknowledge</span><br><span>@@ -1412,7 +1412,7 @@</span><br><span> // <i> Number of stop bits in USART frame</span><br><span> // <id> usart_stop_bit</span><br><span> #ifndef CONF_SERCOM_5_USART_SBMODE</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_5_USART_SBMODE 0</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_5_USART_SBMODE 1</span><br><span> #endif</span><br><span> </span><br><span> // <o> Baud rate <1-3000000></span><br><span>@@ -1430,7 +1430,7 @@</span><br><span> // <i> Define ISO7816 protocol type as 0.</span><br><span> // <id> usart_iso7816_type</span><br><span> #ifndef CONF_SERCOM_5_USART_ISO7816_PROTOCOL_T</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_5_USART_ISO7816_PROTOCOL_T 0x1</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_5_USART_ISO7816_PROTOCOL_T 0x0</span><br><span> #endif</span><br><span> </span><br><span> // <o> ISO7816 Inhibit Not Acknowledge</span><br><span>@@ -1684,7 +1684,7 @@</span><br><span> // <i> Number of stop bits in USART frame</span><br><span> // <id> usart_stop_bit</span><br><span> #ifndef CONF_SERCOM_6_USART_SBMODE</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_6_USART_SBMODE 0</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_6_USART_SBMODE 1</span><br><span> #endif</span><br><span> </span><br><span> // <o> Baud rate <1-3000000></span><br><span>@@ -1702,7 +1702,7 @@</span><br><span> // <i> Define ISO7816 protocol type as 0.</span><br><span> // <id> usart_iso7816_type</span><br><span> #ifndef CONF_SERCOM_6_USART_ISO7816_PROTOCOL_T</span><br><span style="color: hsl(0, 100%, 40%);">-#define CONF_SERCOM_6_USART_ISO7816_PROTOCOL_T 0x1</span><br><span style="color: hsl(120, 100%, 40%);">+#define CONF_SERCOM_6_USART_ISO7816_PROTOCOL_T 0x0</span><br><span> #endif</span><br><span> </span><br><span> // <o> ISO7816 Inhibit Not Acknowledge</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16265">change 16265</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16265"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie6cb7ec51036f1de15c83b59d130f3cb85309594 </div>
<div style="display:none"> Gerrit-Change-Number: 16265 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>