<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16322">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">introduce MNCC_Emulation mp_mncc_version<br><br>Default the MNCC version to the current osmo-sip-connector's master branch MNCC<br>version.<br><br>As soon as the new version (6) is merged, we can bump it here to make tests for<br>master work again.<br><br>For 'latest' builds, we can adjust osmo-ttcn3-hacks to use version 5, and also<br>see those tests still passing.<br><br>Change-Id: I3eb6e0132dc99ebe41a98cc5c329ed4864b770d6<br>---<br>M library/MNCC_Emulation.ttcn<br>M sip/SIP_Tests.default<br>2 files changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/MNCC_Emulation.ttcn b/library/MNCC_Emulation.ttcn</span><br><span>index ee9b58e..9522e72 100644</span><br><span>--- a/library/MNCC_Emulation.ttcn</span><br><span>+++ b/library/MNCC_Emulation.ttcn</span><br><span>@@ -37,6 +37,10 @@</span><br><span> import from MNCC_Types all;</span><br><span> import from UD_Types all;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+modulepar {</span><br><span style="color: hsl(120, 100%, 40%);">+  int mp_mncc_version := 5;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* General "base class" component definition, of which specific implementations</span><br><span>  * derive themselves by means of the "extends" feature */</span><br><span> type component MNCC_ConnHdlr {</span><br><span>@@ -264,7 +268,7 @@</span><br><span> </span><br><span>       if (role_server) {</span><br><span>           f_listen(sock);</span><br><span style="color: hsl(0, 100%, 40%);">-         MNCC.send(t_SD_MNCC(g_mncc_ud_id, ts_MNCC_HELLO));</span><br><span style="color: hsl(120, 100%, 40%);">+            MNCC.send(t_SD_MNCC(g_mncc_ud_id, ts_MNCC_HELLO(version := mp_mncc_version)));</span><br><span>       } else {</span><br><span>             f_connect(sock);</span><br><span>     }</span><br><span>diff --git a/sip/SIP_Tests.default b/sip/SIP_Tests.default</span><br><span>index 4434a1a..9fcd387 100644</span><br><span>--- a/sip/SIP_Tests.default</span><br><span>+++ b/sip/SIP_Tests.default</span><br><span>@@ -25,6 +25,7 @@</span><br><span> </span><br><span> [MODULE_PARAMETERS]</span><br><span> Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoSIPcon";</span><br><span style="color: hsl(120, 100%, 40%);">+MNCC_Emulation.mp_mncc_version := 5;</span><br><span> </span><br><span> [MAIN_CONTROLLER]</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16322">change 16322</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16322"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3eb6e0132dc99ebe41a98cc5c329ed4864b770d6 </div>
<div style="display:none"> Gerrit-Change-Number: 16322 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>