<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16187">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  laforge: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">e1cap_dump: fix superchannel without pcap output<br><br>We have to check if g_pcap_fd is >= 0,as we initialize it to -1.<br><br>Change-Id: I458c02b4619b6fb2c7d30b1ce3bbac86243a6977<br>---<br>M src/e1cap_dump.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/e1cap_dump.c b/src/e1cap_dump.c</span><br><span>index 027aa82..c172b55 100644</span><br><span>--- a/src/e1cap_dump.c</span><br><span>+++ b/src/e1cap_dump.c</span><br><span>@@ -78,7 +78,7 @@</span><br><span> static void handle_hdlc_frame_content(const uint8_t *data, unsigned int len,</span><br><span>                                  void *priv)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  if (g_pcap_fd && len >= 4) {</span><br><span style="color: hsl(120, 100%, 40%);">+       if (g_pcap_fd >= 0 && len >= 4) {</span><br><span>              uint8_t *cur = msgb_put(g_pcap_msg, len-2);</span><br><span>          memcpy(cur, data, len-2);</span><br><span>            printf("==> %s\n", msgb_hexdump(g_pcap_msg));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16187">change 16187</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16187"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-recorder </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I458c02b4619b6fb2c7d30b1ce3bbac86243a6977 </div>
<div style="display:none"> Gerrit-Change-Number: 16187 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>