<p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c">File src/mslookup/mslookup.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c@52">Patch Set #14, Line 52:</a> <code style="font-family:monospace,monospace"> * src/mslookup/mslookup_client_mdns.c lookup method implementing multicast DNS, client side.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This line should go in next patches but fine.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c@56">Patch Set #14, Line 56:</a> <code style="font-family:monospace,monospace"> * src/mslookup/mslookup_client_fake.c lookup method generating fake results, for testing client implementations.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Better put this one after mslookup_client.c</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c@58">Patch Set #14, Line 58:</a> <code style="font-family:monospace,monospace"> * src/mslookup/mdns*.c implementation of DNS to be used by mslookup_client_mdns.c,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You may want to put that inside (1), before (1a) since it's for both 1a and 1b.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c@61">Patch Set #14, Line 61:</a> <code style="font-family:monospace,monospace"> * contrib/dgsm/esme_dgsm.py Example implementation for an mslookup enabled SMS handler.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">utils/?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c@80">Patch Set #14, Line 80:</a> <code style="font-family:monospace,monospace"> * src/proxy.c Keep track of proxied IMSIs and cache important subscriber data.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">is code in this file going to be used outside of dgsm scope? if not, sounds like it should be renamed to dgsm_proxy.c or dgsm_cache.c or alike.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c@91">Patch Set #14, Line 91:</a> <code style="font-family:monospace,monospace">#define CMP(a,b) (a < b? -1 : (a > b? 1 : 0))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Don't we have an OSMO_CMP somewhere for that? BTW, missing () around a and b. Missing space after b.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c@214">Patch Set #14, Line 214:</a> <code style="font-family:monospace,monospace"> if (result->host_v4.ip[0]) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">!= '\0'. I had to go look into the header then into "struct osmo_sockaddr_str" @ libosmocore to find if that was a string or some kind of pointer.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup.c@218">Patch Set #14, Line 218:</a> <code style="font-family:monospace,monospace"> if (result->host_v6.ip[0]) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup_client.c">File src/mslookup/mslookup_client.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202/14/src/mslookup/mslookup_client.c@72">Patch Set #14, Line 72:</a> <code style="font-family:monospace,monospace"> if (!client)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do we really expect someone to call this function with a null pointer? I wouldn't expect it. Add an assert if you are afraid about bad use.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202">change 16202</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16202"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I83487ab8aad1611eb02e997dafbcb8344da13df1 </div>
<div style="display:none"> Gerrit-Change-Number: 16202 </div>
<div style="display:none"> Gerrit-PatchSet: 14 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 27 Nov 2019 14:09:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>