<p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/ccid_device.c">File ccid_common/ccid_device.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/ccid_device.c@27">Patch Set #1, Line 27:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">//     if (in->bmTCCKST0 & 0xFD)<br>//            return -11;<br>// 6.1.7 say<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Osmocom uses mainly kernel coding style and hence /* style comments.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/iso7816_fsm.c">File ccid_common/iso7816_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/iso7816_fsm.c@383">Patch Set #1, Line 383:</a> <code style="font-family:monospace,monospace">//      struct iso7816_3_priv *ip = get_iso7816_3_priv(parent_fi);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237/1/ccid_common/iso7816_fsm.c@389">Patch Set #1, Line 389:</a> <code style="font-family:monospace,monospace">             break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237">change 16237</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2e226b0033f8a147fad60a33a63cc45ee9adc756 </div>
<div style="display:none"> Gerrit-Change-Number: 16237 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Nov 2019 23:14:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>