<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/16234">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ansible: Fix several file permission mask format<br><br>From ansible documentation [1]:<br>"""<br>For those used to /usr/bin/chmod remember that modes are actually octal<br>numbers. You must either add a leading zero so that Ansible's YAML<br>parser knows it is an octal number (like 0644 or 01777) or quote it<br>(like '644' or '1777') so Ansible receives a string and can do its own<br>conversion from string into number.<br>Giving Ansible a number without following one of these rules will end up<br>with a decimal number which will have unexpected results.<br>"""<br><br>[1] https://docs.ansible.com/ansible/latest/modules/template_module.html?highlight=template<br><br>Change-Id: I91008927c50016a837420c4249b5f69b9153572e<br>---<br>M ansible/roles/gsm-tester/tasks/main.yml<br>M ansible/roles/install-coverity/tasks/main.yml<br>M ansible/roles/install-poky-sdk/tasks/main.yml<br>3 files changed, 7 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/16234/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ansible/roles/gsm-tester/tasks/main.yml b/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>index 34846a5..d880127 100644</span><br><span>--- a/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>+++ b/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>@@ -191,7 +191,7 @@</span><br><span>   file:</span><br><span>     path: /usr/sbin/tcpdump</span><br><span>     group: osmo-gsm-tester</span><br><span style="color: hsl(0, 100%, 40%);">-    mode: 750</span><br><span style="color: hsl(120, 100%, 40%);">+    mode: 0750</span><br><span> </span><br><span> - name: create a symlink for tcpdump</span><br><span>   file:</span><br><span>@@ -219,7 +219,7 @@</span><br><span>   copy:</span><br><span>     src: osmo-gsm-tester_setcap_net_raw.sh</span><br><span>     dest: /usr/local/bin/osmo-gsm-tester_setcap_net_raw.sh</span><br><span style="color: hsl(0, 100%, 40%);">-    mode: 755</span><br><span style="color: hsl(120, 100%, 40%);">+    mode: 0755</span><br><span> </span><br><span> - name: allow osmo-gsm-tester sudo osmo-gsm-tester_setcap_net_raw.sh</span><br><span>   copy:</span><br><span>@@ -232,7 +232,7 @@</span><br><span>   copy:</span><br><span>     src: osmo-gsm-tester_setcap_net_admin.sh</span><br><span>     dest: /usr/local/bin/osmo-gsm-tester_setcap_net_admin.sh</span><br><span style="color: hsl(0, 100%, 40%);">-    mode: 755</span><br><span style="color: hsl(120, 100%, 40%);">+    mode: 0755</span><br><span> </span><br><span> - name: allow osmo-gsm-tester sudo osmo-gsm-tester_setcap_net_admin.sh</span><br><span>   copy:</span><br><span>@@ -245,7 +245,7 @@</span><br><span>   copy:</span><br><span>     src: osmo-gsm-tester_netns_exec.sh</span><br><span>     dest: /usr/local/bin/osmo-gsm-tester_netns_exec.sh</span><br><span style="color: hsl(0, 100%, 40%);">-    mode: 755</span><br><span style="color: hsl(120, 100%, 40%);">+    mode: 0755</span><br><span> </span><br><span> - name: allow osmo-gsm-tester sudo osmo-gsm-tester_netns_exec.sh</span><br><span>   copy:</span><br><span>@@ -258,7 +258,7 @@</span><br><span>   copy:</span><br><span>     src: osmo-gsm-tester_netns_setup.sh</span><br><span>     dest: /usr/local/bin/osmo-gsm-tester_netns_setup.sh</span><br><span style="color: hsl(0, 100%, 40%);">-    mode: 755</span><br><span style="color: hsl(120, 100%, 40%);">+    mode: 0755</span><br><span> </span><br><span> - name: allow osmo-gsm-tester sudo osmo-gsm-tester_netns_setup.sh</span><br><span>   copy:</span><br><span>diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml</span><br><span>index 200a349..886dda2 100644</span><br><span>--- a/ansible/roles/install-coverity/tasks/main.yml</span><br><span>+++ b/ansible/roles/install-coverity/tasks/main.yml</span><br><span>@@ -3,7 +3,7 @@</span><br><span>   copy:</span><br><span>     src: "{{ coverity_installer_file }}"</span><br><span>     dest: "/tmp/{{ coverity_installer_file }}"</span><br><span style="color: hsl(0, 100%, 40%);">-    mode: 750</span><br><span style="color: hsl(120, 100%, 40%);">+    mode: 0750</span><br><span>   register: coverity_copy</span><br><span>   ignore_errors: yes</span><br><span>   tags: [coverity]</span><br><span>@@ -36,4 +36,3 @@</span><br><span>     msg: "Ansible can not find {{ coverity_installer_file }}"</span><br><span>   when: coverity_copy.failed</span><br><span>   tags: [coverity]</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml b/ansible/roles/install-poky-sdk/tasks/main.yml</span><br><span>index 85b310a..7f95dce 100644</span><br><span>--- a/ansible/roles/install-poky-sdk/tasks/main.yml</span><br><span>+++ b/ansible/roles/install-poky-sdk/tasks/main.yml</span><br><span>@@ -12,7 +12,7 @@</span><br><span>   copy:</span><br><span>     src: "{{ poky_installer_file }}"</span><br><span>     dest: "/tmp/{{ poky_installer_file }}"</span><br><span style="color: hsl(0, 100%, 40%);">-    mode: 750</span><br><span style="color: hsl(120, 100%, 40%);">+    mode: 0750</span><br><span>   register: poky_copy</span><br><span>   ignore_errors: yes</span><br><span>   tags: [poky]</span><br><span>@@ -45,4 +45,3 @@</span><br><span>     msg: "Ansible can not find or copy {{ poky_installer_file }}"</span><br><span>   when: poky_copy.failed</span><br><span>   tags: [poky]</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/16234">change 16234</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/16234"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I91008927c50016a837420c4249b5f69b9153572e </div>
<div style="display:none"> Gerrit-Change-Number: 16234 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>