<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

Objections:
  zecke: I would prefer this is not merged as is

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">exit if the sip agent failed to start<br><br>When the sip agent start fails (i.e. port can not bind<br>because IP doesn't exist) exit the sip-connector<br><br>Relates: OS#4197<br>Change-Id: I22ed16c77391b4f270df498dda587ed657279390<br>---<br>M src/main.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/main.c b/src/main.c</span><br><span>index 13fdd5d..3385e37 100644</span><br><span>--- a/src/main.c</span><br><span>+++ b/src/main.c</span><br><span>@@ -158,9 +158,11 @@</span><br><span>     /* sofia sip */</span><br><span>      sip_agent_init(&g_app.sip.agent, &g_app);</span><br><span>    rc = sip_agent_start(&g_app.sip.agent);</span><br><span style="color: hsl(0, 100%, 40%);">-     if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (rc < 0) {</span><br><span>             LOGP(DSIP, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-                  "Failed to initialize SIP. Running broken\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                      "Failed to initialize SIP\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              exit(1);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span> </span><br><span>        calls_init();</span><br><span>        app_setup(&g_app);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532">change 15532</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I22ed16c77391b4f270df498dda587ed657279390 </div>
<div style="display:none"> Gerrit-Change-Number: 15532 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: zecke <holger@freyther.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>