<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/16137">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Verified
  osmith: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">respawn.sh: Add logging and limit loop iterations<br><br>Since we'll now log the script and its children output to a file, let's<br>make sure the loop doesn't run countless times upon failing child<br>process, producing lots of potential undesired output. For instance, if<br>osmo-bts fails to read vty config and exits immediately.<br><br>Change-Id: Icc8cac889d94d4cce7d6365781d5b5364404b5b9<br>---<br>M osmo-bts-latest/respawn.sh<br>M osmo-bts-master/respawn.sh<br>M osmo-pcu-latest/respawn.sh<br>M osmo-pcu-master/respawn.sh<br>4 files changed, 28 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/osmo-bts-latest/respawn.sh b/osmo-bts-latest/respawn.sh</span><br><span>index ae5cf60..2413916 100755</span><br><span>--- a/osmo-bts-latest/respawn.sh</span><br><span>+++ b/osmo-bts-latest/respawn.sh</span><br><span>@@ -2,8 +2,14 @@</span><br><span> </span><br><span> trap "kill 0" EXIT</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-while [ -e /etc/passwd ]; do</span><br><span style="color: hsl(120, 100%, 40%);">+i=0</span><br><span style="color: hsl(120, 100%, 40%);">+max_i=500</span><br><span style="color: hsl(120, 100%, 40%);">+while [ $i -lt $max_i ]; do</span><br><span style="color: hsl(120, 100%, 40%);">+      echo "$i: starting: $*"</span><br><span>    $* &</span><br><span>     LAST_PID=$!</span><br><span>  wait $LAST_PID</span><br><span style="color: hsl(120, 100%, 40%);">+        echo "$i: stopped pid $LAST_PID with status $?"</span><br><span style="color: hsl(120, 100%, 40%);">+     i=$(expr $i + 1)</span><br><span> done</span><br><span style="color: hsl(120, 100%, 40%);">+echo "exiting after $max_i runs"</span><br><span>diff --git a/osmo-bts-master/respawn.sh b/osmo-bts-master/respawn.sh</span><br><span>index ae5cf60..2413916 100755</span><br><span>--- a/osmo-bts-master/respawn.sh</span><br><span>+++ b/osmo-bts-master/respawn.sh</span><br><span>@@ -2,8 +2,14 @@</span><br><span> </span><br><span> trap "kill 0" EXIT</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-while [ -e /etc/passwd ]; do</span><br><span style="color: hsl(120, 100%, 40%);">+i=0</span><br><span style="color: hsl(120, 100%, 40%);">+max_i=500</span><br><span style="color: hsl(120, 100%, 40%);">+while [ $i -lt $max_i ]; do</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "$i: starting: $*"</span><br><span>    $* &</span><br><span>     LAST_PID=$!</span><br><span>  wait $LAST_PID</span><br><span style="color: hsl(120, 100%, 40%);">+        echo "$i: stopped pid $LAST_PID with status $?"</span><br><span style="color: hsl(120, 100%, 40%);">+     i=$(expr $i + 1)</span><br><span> done</span><br><span style="color: hsl(120, 100%, 40%);">+echo "exiting after $max_i runs"</span><br><span>diff --git a/osmo-pcu-latest/respawn.sh b/osmo-pcu-latest/respawn.sh</span><br><span>index ae5cf60..2413916 100755</span><br><span>--- a/osmo-pcu-latest/respawn.sh</span><br><span>+++ b/osmo-pcu-latest/respawn.sh</span><br><span>@@ -2,8 +2,14 @@</span><br><span> </span><br><span> trap "kill 0" EXIT</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-while [ -e /etc/passwd ]; do</span><br><span style="color: hsl(120, 100%, 40%);">+i=0</span><br><span style="color: hsl(120, 100%, 40%);">+max_i=500</span><br><span style="color: hsl(120, 100%, 40%);">+while [ $i -lt $max_i ]; do</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "$i: starting: $*"</span><br><span>    $* &</span><br><span>     LAST_PID=$!</span><br><span>  wait $LAST_PID</span><br><span style="color: hsl(120, 100%, 40%);">+        echo "$i: stopped pid $LAST_PID with status $?"</span><br><span style="color: hsl(120, 100%, 40%);">+     i=$(expr $i + 1)</span><br><span> done</span><br><span style="color: hsl(120, 100%, 40%);">+echo "exiting after $max_i runs"</span><br><span>diff --git a/osmo-pcu-master/respawn.sh b/osmo-pcu-master/respawn.sh</span><br><span>index ae5cf60..2413916 100755</span><br><span>--- a/osmo-pcu-master/respawn.sh</span><br><span>+++ b/osmo-pcu-master/respawn.sh</span><br><span>@@ -2,8 +2,14 @@</span><br><span> </span><br><span> trap "kill 0" EXIT</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-while [ -e /etc/passwd ]; do</span><br><span style="color: hsl(120, 100%, 40%);">+i=0</span><br><span style="color: hsl(120, 100%, 40%);">+max_i=500</span><br><span style="color: hsl(120, 100%, 40%);">+while [ $i -lt $max_i ]; do</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "$i: starting: $*"</span><br><span>    $* &</span><br><span>     LAST_PID=$!</span><br><span>  wait $LAST_PID</span><br><span style="color: hsl(120, 100%, 40%);">+        echo "$i: stopped pid $LAST_PID with status $?"</span><br><span style="color: hsl(120, 100%, 40%);">+     i=$(expr $i + 1)</span><br><span> done</span><br><span style="color: hsl(120, 100%, 40%);">+echo "exiting after $max_i runs"</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/16137">change 16137</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/16137"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icc8cac889d94d4cce7d6365781d5b5364404b5b9 </div>
<div style="display:none"> Gerrit-Change-Number: 16137 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>