<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/15997">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bankd_client_fsm: close IPA client connection before re-establishing it<br><br>ipa_client_conn_destroy() really only destroys the object, but not close<br>the underlying file descriptor.  This leads to old connections<br>lingering around, which in turn (in case of the remsim client) will<br>occupy banksim worker threads.<br><br>Change-Id: If87f4bbc133e4dc812fa96a75e8495bad65275aa<br>---<br>M src/bankd_client_fsm.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bankd_client_fsm.c b/src/bankd_client_fsm.c</span><br><span>index 8cc773a..cedb597 100644</span><br><span>--- a/src/bankd_client_fsm.c</span><br><span>+++ b/src/bankd_client_fsm.c</span><br><span>@@ -152,6 +152,7 @@</span><br><span>  /* re-create bankd_conn */</span><br><span>   if (bc->bankd_conn) {</span><br><span>             LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to bankd\n");</span><br><span style="color: hsl(120, 100%, 40%);">+               ipa_client_conn_close(bc->bankd_conn);</span><br><span>            ipa_client_conn_destroy(bc->bankd_conn);</span><br><span>          bc->bankd_conn = NULL;</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/15997">change 15997</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/15997"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If87f4bbc133e4dc812fa96a75e8495bad65275aa </div>
<div style="display:none"> Gerrit-Change-Number: 15997 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>