<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16160">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add osmo_escape_c_str and osmo_quote_c_str<br><br>Provide string escaping that<br>- returns the required buffer size, so it can be used with OSMO_STRBUF_APPEND().<br>- uses C compatible string constant escaping sequences.<br><br>This is intended as a replacement for all previous osmo_escape_str* and<br>osmo_quote_str* API. It pains me that I didn't get them right the first nor the<br>second time:<br>- The buffer functions do not return the chars needed, which is required for<br> allocating sufficient memory in the *_c versions of the functions.<br>- Because of that, these functions are accurately usable for<br> OSMO_STRBUF_APPEND(), producing truncated strings, for example when dumping a<br> GSUP message.<br>- They do not use the C equivalent string constant escaping: for some reason I<br> thought "\15" would be valid, but it should be "\x0f".<br>If I could, I would completely drop those mislead implementations ... but<br>backwards compat prohibits that.<br><br>A previous patch already provided internal static functions that accurately<br>return the required buffer size. Enhance these to also support C compatible<br>string escaping, and use them as implementation of the new functions:<br><br>osmo_escape_cstr_buf()<br>osmo_escape_cstr_c()<br>osmo_quote_cstr_buf()<br>osmo_quote_cstr_c()<br><br>In the tests for these, also test C string equivalence.<br><br>Naming: from API versions, it would be kind of logical to call them<br>osmo_escape_str_buf3() and osmo_escape_str_c2(). Since these anyway return a<br>different escaping, it makes sense to me to have distinct names instead.<br><br>Quasi missing are variants of the non-C-compatible weird legacy escaping that<br>return the required buffer size, but I refrain from adding those, because we<br>have enough API cruft as it is. Just always use these new cstr variants.<br><br>Change-Id: I3dfb892036e01000033dd8e7e4a6a0c32a3caa9b<br>---<br>M include/osmocom/core/utils.h<br>M src/utils.c<br>M tests/utils/utils_test.c<br>M tests/utils/utils_test.ok<br>4 files changed, 301 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/16160/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h</span><br><span>index 86d45bc..4e7037a 100644</span><br><span>--- a/include/osmocom/core/utils.h</span><br><span>+++ b/include/osmocom/core/utils.h</span><br><span>@@ -147,6 +147,11 @@</span><br><span> bool osmo_separated_identifiers_valid(const char *str, const char *sep_chars);</span><br><span> void osmo_identifier_sanitize_buf(char *str, const char *sep_chars, char replace_with);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+size_t osmo_escape_cstr_buf(char *buf, size_t bufsize, const char *str, int in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+char *osmo_escape_cstr_c(void *ctx, const char *str, int in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+size_t osmo_quote_cstr_buf(char *buf, size_t bufsize, const char *str, int in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+char *osmo_quote_cstr_c(void *ctx, const char *str, int in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> const char *osmo_escape_str(const char *str, int len);</span><br><span> char *osmo_escape_str_buf2(char *buf, size_t bufsize, const char *str, int in_len);</span><br><span> const char *osmo_escape_str_buf(const char *str, int in_len, char *buf, size_t bufsize);</span><br><span>diff --git a/src/utils.c b/src/utils.c</span><br><span>index 904f6e4..8dfa7ec 100644</span><br><span>--- a/src/utils.c</span><br><span>+++ b/src/utils.c</span><br><span>@@ -669,14 +669,18 @@</span><br><span> </span><br><span> /*! Return the string with all non-printable characters escaped.</span><br><span> * This internal function is the implementation for all osmo_escape_str* and osmo_quote_str* API versions.</span><br><span style="color: hsl(0, 100%, 40%);">- * It provides a return value of characters-needed, to allow producing un-truncated strings in all cases.</span><br><span style="color: hsl(120, 100%, 40%);">+ * It provides both the legacy (non C compatible) escaping, as well as C compatible string constant syntax,</span><br><span style="color: hsl(120, 100%, 40%);">+ * and it provides a return value of characters-needed, to allow producing un-truncated strings in all cases.</span><br><span> * \param[out] buf string buffer to write escaped characters to.</span><br><span> * \param[in] bufsize sizeof(buf).</span><br><span> * \param[in] str A string that may contain any characters.</span><br><span> * \param[in] in_len Pass -1 to print until nul char, or >= 0 to force a length (also past nul chars).</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] legacy_format If false, return C compatible string constants ("\x0f"), if true the legacy</span><br><span style="color: hsl(120, 100%, 40%);">+ * escaping format ("\15"). The legacy format also escapes as "\a\b\f\v", while</span><br><span style="color: hsl(120, 100%, 40%);">+ * the non-legacy format also escapes those as "\xNN" sequences.</span><br><span> * \return Number of characters that would be written if bufsize were large enough excluding '\0' (like snprintf()).</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-static size_t _osmo_escape_str_buf(char *buf, size_t bufsize, const char *str, int in_len)</span><br><span style="color: hsl(120, 100%, 40%);">+static size_t _osmo_escape_str_buf(char *buf, size_t bufsize, const char *str, int in_len, bool legacy_format)</span><br><span> {</span><br><span> struct osmo_strbuf sb = { .buf = buf, .len = bufsize };</span><br><span> int in_pos = 0;</span><br><span>@@ -715,19 +719,28 @@</span><br><span> BACKSLASH_CASE('\r', 'r');</span><br><span> BACKSLASH_CASE('\t', 't');</span><br><span> BACKSLASH_CASE('\0', '0');</span><br><span style="color: hsl(0, 100%, 40%);">- BACKSLASH_CASE('\a', 'a');</span><br><span style="color: hsl(0, 100%, 40%);">- BACKSLASH_CASE('\b', 'b');</span><br><span style="color: hsl(0, 100%, 40%);">- BACKSLASH_CASE('\v', 'v');</span><br><span style="color: hsl(0, 100%, 40%);">- BACKSLASH_CASE('\f', 'f');</span><br><span> BACKSLASH_CASE('\\', '\\');</span><br><span> BACKSLASH_CASE('"', '"');</span><br><span style="color: hsl(0, 100%, 40%);">-#undef BACKSLASH_CASE</span><br><span> </span><br><span> default:</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_STRBUF_PRINTF(sb, "\\%u", (unsigned char)str[in_pos]);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (legacy_format) {</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (str[next_unprintable]) {</span><br><span style="color: hsl(120, 100%, 40%);">+ BACKSLASH_CASE('\a', 'a');</span><br><span style="color: hsl(120, 100%, 40%);">+ BACKSLASH_CASE('\b', 'b');</span><br><span style="color: hsl(120, 100%, 40%);">+ BACKSLASH_CASE('\v', 'v');</span><br><span style="color: hsl(120, 100%, 40%);">+ BACKSLASH_CASE('\f', 'f');</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_STRBUF_PRINTF(sb, "\\%u", (unsigned char)str[in_pos]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_STRBUF_PRINTF(sb, "\\x%02x", (unsigned char)str[in_pos]);</span><br><span> break;</span><br><span> }</span><br><span> in_pos ++;</span><br><span style="color: hsl(120, 100%, 40%);">+#undef BACKSLASH_CASE</span><br><span> }</span><br><span> </span><br><span> done:</span><br><span>@@ -743,7 +756,7 @@</span><br><span> */</span><br><span> char *osmo_escape_str_buf2(char *buf, size_t bufsize, const char *str, int in_len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- _osmo_escape_str_buf(buf, bufsize, str, in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ _osmo_escape_str_buf(buf, bufsize, str, in_len, true);</span><br><span> return buf;</span><br><span> }</span><br><span> </span><br><span>@@ -767,26 +780,30 @@</span><br><span> {</span><br><span> /* The string will be at least as long as in_len, but some characters might need escaping.</span><br><span> * These extra bytes should catch most usual escaping situations, avoiding a second run in OSMO_NAME_C_IMPL. */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_NAME_C_IMPL(ctx, in_len + 16, "ERROR", _osmo_escape_str_buf, str, in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_NAME_C_IMPL(ctx, in_len + 16, "ERROR", _osmo_escape_str_buf, str, in_len, true);</span><br><span> }</span><br><span> </span><br><span> /*! Return a quoted and escaped representation of the string.</span><br><span> * This internal function is the implementation for all osmo_quote_str* API versions.</span><br><span style="color: hsl(0, 100%, 40%);">- * It provides a return value of characters-needed, to allow producing un-truncated strings in all cases.</span><br><span style="color: hsl(120, 100%, 40%);">+ * It provides both the legacy (non C compatible) escaping, as well as C compatible string constant syntax,</span><br><span style="color: hsl(120, 100%, 40%);">+ * and it provides a return value of characters-needed, to allow producing un-truncated strings in all cases.</span><br><span> * \param[out] buf string buffer to write escaped characters to.</span><br><span> * \param[in] bufsize sizeof(buf).</span><br><span> * \param[in] str A string that may contain any characters.</span><br><span> * \param[in] in_len Pass -1 to print until nul char, or >= 0 to force a length (also past nul chars).</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] legacy_format If false, return C compatible string constants ("\x0f"), if true the legacy</span><br><span style="color: hsl(120, 100%, 40%);">+ * escaping format ("\15"). The legacy format also escapes as "\a\b\f\v", while</span><br><span style="color: hsl(120, 100%, 40%);">+ * the non-legacy format also escapes those as "\xNN" sequences.</span><br><span> * \return Number of characters that would be written if bufsize were large enough excluding '\0' (like snprintf()).</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-static size_t _osmo_quote_str_buf(char *buf, size_t bufsize, const char *str, int in_len)</span><br><span style="color: hsl(120, 100%, 40%);">+static size_t _osmo_quote_str_buf(char *buf, size_t bufsize, const char *str, int in_len, bool legacy_format)</span><br><span> {</span><br><span> struct osmo_strbuf sb = { .buf = buf, .len = bufsize };</span><br><span> if (!str)</span><br><span> OSMO_STRBUF_PRINTF(sb, "NULL");</span><br><span> else {</span><br><span> OSMO_STRBUF_PRINTF(sb, "\"");</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_STRBUF_APPEND(sb, _osmo_escape_str_buf, str, in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_STRBUF_APPEND(sb, _osmo_escape_str_buf, str, in_len, legacy_format);</span><br><span> OSMO_STRBUF_PRINTF(sb, "\"");</span><br><span> }</span><br><span> return sb.chars_needed;</span><br><span>@@ -803,7 +820,7 @@</span><br><span> */</span><br><span> char *osmo_quote_str_buf2(char *buf, size_t bufsize, const char *str, int in_len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- _osmo_quote_str_buf(buf, bufsize, str, in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ _osmo_quote_str_buf(buf, bufsize, str, in_len, true);</span><br><span> return buf;</span><br><span> }</span><br><span> </span><br><span>@@ -821,7 +838,7 @@</span><br><span> return "NULL";</span><br><span> if (!buf || !bufsize)</span><br><span> return "(error)";</span><br><span style="color: hsl(0, 100%, 40%);">- _osmo_quote_str_buf(buf, bufsize, str, in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ _osmo_quote_str_buf(buf, bufsize, str, in_len, true);</span><br><span> return buf;</span><br><span> }</span><br><span> </span><br><span>@@ -833,7 +850,7 @@</span><br><span> */</span><br><span> const char *osmo_quote_str(const char *str, int in_len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- _osmo_quote_str_buf(namebuf, sizeof(namebuf), str, in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ _osmo_quote_str_buf(namebuf, sizeof(namebuf), str, in_len, true);</span><br><span> return namebuf;</span><br><span> }</span><br><span> </span><br><span>@@ -846,7 +863,65 @@</span><br><span> {</span><br><span> /* The string will be at least as long as in_len, but some characters might need escaping.</span><br><span> * These extra bytes should catch most usual escaping situations, avoiding a second run in OSMO_NAME_C_IMPL. */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_NAME_C_IMPL(ctx, in_len + 16, "ERROR", _osmo_quote_str_buf, str, in_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_NAME_C_IMPL(ctx, in_len + 16, "ERROR", _osmo_quote_str_buf, str, in_len, true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Return the string with all non-printable characters escaped.</span><br><span style="color: hsl(120, 100%, 40%);">+ * In contrast to osmo_escape_str_buf2(), this returns the needed buffer size suitable for OSMO_STRBUF_APPEND(), and</span><br><span style="color: hsl(120, 100%, 40%);">+ * this escapes characters in a way compatible with C string constant syntax.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[out] buf string buffer to write escaped characters to.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] bufsize sizeof(buf).</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] str A string that may contain any characters.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] in_len Pass -1 to print until nul char, or >= 0 to force a length (also past nul chars).</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return Number of characters that would be written if bufsize were large enough excluding '\0' (like snprintf()).</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+size_t osmo_escape_cstr_buf(char *buf, size_t bufsize, const char *str, int in_len)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ return _osmo_escape_str_buf(buf, bufsize, str, in_len, false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Return the string with all non-printable characters escaped, in dynamically-allocated buffer.</span><br><span style="color: hsl(120, 100%, 40%);">+ * In contrast to osmo_escape_str_c(), this escapes characters in a way compatible with C string constant syntax, and</span><br><span style="color: hsl(120, 100%, 40%);">+ * allocates sufficient memory in all cases.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] str A string that may contain any characters.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] len Pass -1 to print until nul char, or >= 0 to force a length.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns dynamically-allocated buffer, containing an escaped representation.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+char *osmo_escape_cstr_c(void *ctx, const char *str, int in_len)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ /* The string will be at least as long as in_len, but some characters might need escaping.</span><br><span style="color: hsl(120, 100%, 40%);">+ * These extra bytes should catch most usual escaping situations, avoiding a second run in OSMO_NAME_C_IMPL. */</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_NAME_C_IMPL(ctx, in_len + 16, "ERROR", _osmo_escape_str_buf, str, in_len, false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Like osmo_escape_str_buf2(), but returns double-quotes around a string, or "NULL" for a NULL string.</span><br><span style="color: hsl(120, 100%, 40%);">+ * This allows passing any char* value and get its C representation as string.</span><br><span style="color: hsl(120, 100%, 40%);">+ * The function signature is suitable for OSMO_STRBUF_APPEND_NOLEN().</span><br><span style="color: hsl(120, 100%, 40%);">+ * In contrast to osmo_escape_str_buf2(), this returns the needed buffer size suitable for OSMO_STRBUF_APPEND(), and</span><br><span style="color: hsl(120, 100%, 40%);">+ * this escapes characters in a way compatible with C string constant syntax.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[out] buf string buffer to write escaped characters to.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] bufsize sizeof(buf).</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] str A string that may contain any characters.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] in_len Pass -1 to print until nul char, or >= 0 to force a length.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return Number of characters that would be written if bufsize were large enough excluding '\0' (like snprintf()).</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+size_t osmo_quote_cstr_buf(char *buf, size_t bufsize, const char *str, int in_len)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ return _osmo_quote_str_buf(buf, bufsize, str, in_len, false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Return the string quoted and with all non-printable characters escaped, in dynamically-allocated buffer.</span><br><span style="color: hsl(120, 100%, 40%);">+ * In contrast to osmo_quote_str_c(), this escapes characters in a way compatible with C string constant syntax, and</span><br><span style="color: hsl(120, 100%, 40%);">+ * allocates sufficient memory in all cases.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] str A string that may contain any characters.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] len Pass -1 to print until nul char, or >= 0 to force a length.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns dynamically-allocated buffer, containing a quoted and escaped representation.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+char *osmo_quote_cstr_c(void *ctx, const char *str, int in_len)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ /* The string will be at least as long as in_len plus two quotes, but some characters might need escaping.</span><br><span style="color: hsl(120, 100%, 40%);">+ * These extra bytes should catch most usual escaping situations, avoiding a second run in OSMO_NAME_C_IMPL. */</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_NAME_C_IMPL(ctx, in_len + 16, "ERROR", _osmo_quote_str_buf, str, in_len, false);</span><br><span> }</span><br><span> </span><br><span> /*! perform an integer square root operation on unsigned 32bit integer.</span><br><span>diff --git a/tests/utils/utils_test.c b/tests/utils/utils_test.c</span><br><span>index 55c9e7f..3c6d17b 100644</span><br><span>--- a/tests/utils/utils_test.c</span><br><span>+++ b/tests/utils/utils_test.c</span><br><span>@@ -531,7 +531,7 @@</span><br><span> const char *printable = "printable";</span><br><span> const char *res;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("\nTesting string escaping\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("\nTesting string escaping: osmo_escape_str()\n");</span><br><span> printf("- all chars from 0 to 255 in batches of 16:\n");</span><br><span> in_buf[16] = '\0';</span><br><span> for (j = 0; j < 16; j++) {</span><br><span>@@ -571,7 +571,7 @@</span><br><span> const char *printable = "printable";</span><br><span> const char *res;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("\nTesting string quoting\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("\nTesting string quoting: osmo_quote_str()\n");</span><br><span> printf("- all chars from 0 to 255 in batches of 16:\n");</span><br><span> in_buf[16] = '\0';</span><br><span> for (j = 0; j < 16; j++) {</span><br><span>@@ -616,6 +616,132 @@</span><br><span> printf("'%s'\n", osmo_quote_str_buf(NULL, -1, out_buf, 10));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void str_escape3_test(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int i;</span><br><span style="color: hsl(120, 100%, 40%);">+ int j;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t in_buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ char out_buf[11];</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *printable = "printable";</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *res;</span><br><span style="color: hsl(120, 100%, 40%);">+ void *ctx = talloc_named_const(NULL, 0, __func__);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("\nTesting string escaping: osmo_escape_cstr_buf()\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- all chars from 0 to 255 in batches of 16:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[16] = '\0';</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 0; j < 16; j++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 16; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[i] = (j << 4) | i;</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("\"%s\"\n", osmo_escape_cstr_c(ctx, (const char*)in_buf, 16));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- nul terminated:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("\"%s\"\n", osmo_escape_cstr_c(ctx, "termi\nated", -1));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- passthru:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ res = osmo_escape_cstr_c(ctx, printable, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (strcmp(res, printable))</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("NOT passed through! \"%s\"\n", res);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("passed through unchanged \"%s\"\n", res);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- zero length:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("\"%s\"\n", osmo_escape_cstr_c(ctx, "omitted", 0));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- truncation when too long:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(in_buf, 'x', sizeof(in_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[0] = '\a';</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[7] = 'E';</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(out_buf, 0x7f, sizeof(out_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_escape_cstr_buf(out_buf, 10, (const char *)in_buf, sizeof(in_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("\"%s\"\n", out_buf);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(out_buf[10] == 0x7f);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- Test escaping an escaped string:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ res = "\x02\x03\n";</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i <= 3; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ res = osmo_escape_cstr_c(ctx, res, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("%d: '%s'\n", i, res);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ talloc_free(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void str_quote3_test(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int i;</span><br><span style="color: hsl(120, 100%, 40%);">+ int j;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t in_buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+ char out_buf[11];</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *printable = "printable";</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *res;</span><br><span style="color: hsl(120, 100%, 40%);">+ void *ctx = talloc_named_const(NULL, 0, __func__);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("\nTesting string quoting: osmo_quote_cstr_buf()\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- all chars from 0 to 255 in batches of 16:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[16] = '\0';</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 0; j < 16; j++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 16; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[i] = (j << 4) | i;</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("%s\n", osmo_quote_cstr_c(ctx, (const char*)in_buf, 16));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- nul terminated:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("'%s'\n", osmo_quote_cstr_c(ctx, "termi\nated", -1));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- never passthru:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ res = osmo_quote_cstr_c(ctx, printable, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (strcmp(res, printable))</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("NOT passed through. '%s'\n", res);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("passed through unchanged '%s'\n", res);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- zero length:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("'%s'\n", osmo_quote_cstr_c(ctx, "omitted", 0));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- truncation when too long:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(in_buf, 'x', sizeof(in_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[0] = '\a';</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[6] = 'E';</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(out_buf, 0x7f, sizeof(out_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_quote_cstr_buf(out_buf, 10, (const char *)in_buf, sizeof(in_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("'%s'\n", out_buf);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(out_buf[10] == 0x7f);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- always truncation, even when no escaping needed:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(in_buf, 'x', sizeof(in_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[7] = 'E'; /* dst has 10, less 1 quote and nul, leaves 8, i.e. in[7] is last */</span><br><span style="color: hsl(120, 100%, 40%);">+ in_buf[20] = '\0';</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(out_buf, 0x7f, sizeof(out_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_quote_cstr_buf(out_buf, 10, (const char *)in_buf, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("'%s'\n", out_buf);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(out_buf[0] == '"');</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(out_buf[10] == 0x7f);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- try to feed too little buf for quoting:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_quote_cstr_buf(out_buf, 2, "", -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("'%s'\n", out_buf);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- Test quoting a quoted+escaped string:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ res = "\x02\x03\n";</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i <= 3; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ res = osmo_quote_cstr_c(ctx, res, -1);</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("%d: %s\n", i, res);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("- Test C-string equivalence:\n");</span><br><span style="color: hsl(120, 100%, 40%);">+#define TEST_STR "\0\x01\x02\x03\x04\x05\x06\x07\x08\t\n\x0b\x0c\r\x0e\x0f\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1a\x1b\x1c\x1d\x1e\x1f !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~\x7f\x80\x81\x82\x83\x84\x85\x86\x87\x88\x89\x8a\x8b\x8c\x8d\x8e\x8f\x90\x91\x92\x93\x94\x95\x96\x97\x98\x99\x9a\x9b\x9c\x9d\x9e\x9f\xa0\xa1\xa2\xa3\xa4\xa5\xa6\xa7\xa8\xa9\xaa\xab\xac\xad\xae\xaf\xb0\xb1\xb2\xb3\xb4\xb5\xb6\xb7\xb8\xb9\xba\xbb\xbc\xbd\xbe\xbf\xc0\xc1\xc2\xc3\xc4\xc5\xc6\xc7\xc8\xc9\xca\xcb\xcc\xcd\xce\xcf\xd0\xd1\xd2\xd3\xd4\xd5\xd6\xd7\xd8\xd9\xda\xdb\xdc\xdd\xde\xdf\xe0\xe1\xe2\xe3\xe4\xe5\xe6\xe7\xe8\xe9\xea\xeb\xec\xed\xee\xef\xf0\xf1\xf2\xf3\xf4\xf5\xf6\xf7\xf8\xf9\xfa\xfb\xfc\xfd\xfe\xff"</span><br><span style="color: hsl(120, 100%, 40%);">+#define EMPTY_STR ""</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("strcmp(OSMO_STRINGIFY_VAL(TEST_STR), osmo_quote_cstr_c(ctx, TEST_STR, 256)) == %d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ strcmp(OSMO_STRINGIFY_VAL(TEST_STR), osmo_quote_cstr_c(ctx, TEST_STR, 256)));</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("strcmp(OSMO_STRINGIFY_VAL(EMPTY_STR), osmo_quote_cstr_c(ctx, EMPTY_STR, -1)) == %d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ strcmp(OSMO_STRINGIFY_VAL(EMPTY_STR), osmo_quote_cstr_c(ctx, EMPTY_STR, -1)));</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("strcmp(\"NULL\", osmo_quote_cstr_c(ctx, NULL, -1)) == %d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ strcmp("NULL", osmo_quote_cstr_c(ctx, NULL, -1)));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ talloc_free(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void isqrt_test(void)</span><br><span> {</span><br><span> int i;</span><br><span>@@ -1152,6 +1278,8 @@</span><br><span> bcd2str_test();</span><br><span> str_escape_test();</span><br><span> str_quote_test();</span><br><span style="color: hsl(120, 100%, 40%);">+ str_escape3_test();</span><br><span style="color: hsl(120, 100%, 40%);">+ str_quote3_test();</span><br><span> isqrt_test();</span><br><span> osmo_sockaddr_to_str_and_uint_test();</span><br><span> osmo_str_tolowupper_test();</span><br><span>diff --git a/tests/utils/utils_test.ok b/tests/utils/utils_test.ok</span><br><span>index b603647..10436ce 100644</span><br><span>--- a/tests/utils/utils_test.ok</span><br><span>+++ b/tests/utils/utils_test.ok</span><br><span>@@ -206,7 +206,7 @@</span><br><span> bcd2str(NULL, ...) -> -12</span><br><span> bcd2str(dst, 0, ...) -> -12</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Testing string escaping</span><br><span style="color: hsl(120, 100%, 40%);">+Testing string escaping: osmo_escape_str()</span><br><span> - all chars from 0 to 255 in batches of 16:</span><br><span> "\0\1\2\3\4\5\6\a\b\t\n\v\f\r\14\15"</span><br><span> "\16\17\18\19\20\21\22\23\24\25\26\27\28\29\30\31"</span><br><span>@@ -233,7 +233,7 @@</span><br><span> - truncation when too long:</span><br><span> "\axxxxxxE"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Testing string quoting</span><br><span style="color: hsl(120, 100%, 40%);">+Testing string quoting: osmo_quote_str()</span><br><span> - all chars from 0 to 255 in batches of 16:</span><br><span> '"\0\1\2\3\4\5\6\a\b\t\n\v\f\r\14\15"'</span><br><span> '"\16\17\18\19\20\21\22\23\24\25\26\27\28\29\30\31"'</span><br><span>@@ -266,6 +266,78 @@</span><br><span> - NULL string becomes a "NULL" literal:</span><br><span> 'NULL'</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+Testing string escaping: osmo_escape_cstr_buf()</span><br><span style="color: hsl(120, 100%, 40%);">+- all chars from 0 to 255 in batches of 16:</span><br><span style="color: hsl(120, 100%, 40%);">+"\0\x01\x02\x03\x04\x05\x06\x07\x08\t\n\x0b\x0c\r\x0e\x0f"</span><br><span style="color: hsl(120, 100%, 40%);">+"\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1a\x1b\x1c\x1d\x1e\x1f"</span><br><span style="color: hsl(120, 100%, 40%);">+" !\"#$%&'()*+,-./"</span><br><span style="color: hsl(120, 100%, 40%);">+"0123456789:;<=>?"</span><br><span style="color: hsl(120, 100%, 40%);">+"@ABCDEFGHIJKLMNO"</span><br><span style="color: hsl(120, 100%, 40%);">+"PQRSTUVWXYZ[\\]^_"</span><br><span style="color: hsl(120, 100%, 40%);">+"`abcdefghijklmno"</span><br><span style="color: hsl(120, 100%, 40%);">+"pqrstuvwxyz{|}~\x7f"</span><br><span style="color: hsl(120, 100%, 40%);">+"\x80\x81\x82\x83\x84\x85\x86\x87\x88\x89\x8a\x8b\x8c\x8d\x8e\x8f"</span><br><span style="color: hsl(120, 100%, 40%);">+"\x90\x91\x92\x93\x94\x95\x96\x97\x98\x99\x9a\x9b\x9c\x9d\x9e\x9f"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xa0\xa1\xa2\xa3\xa4\xa5\xa6\xa7\xa8\xa9\xaa\xab\xac\xad\xae\xaf"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xb0\xb1\xb2\xb3\xb4\xb5\xb6\xb7\xb8\xb9\xba\xbb\xbc\xbd\xbe\xbf"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xc0\xc1\xc2\xc3\xc4\xc5\xc6\xc7\xc8\xc9\xca\xcb\xcc\xcd\xce\xcf"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xd0\xd1\xd2\xd3\xd4\xd5\xd6\xd7\xd8\xd9\xda\xdb\xdc\xdd\xde\xdf"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xe0\xe1\xe2\xe3\xe4\xe5\xe6\xe7\xe8\xe9\xea\xeb\xec\xed\xee\xef"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xf0\xf1\xf2\xf3\xf4\xf5\xf6\xf7\xf8\xf9\xfa\xfb\xfc\xfd\xfe\xff"</span><br><span style="color: hsl(120, 100%, 40%);">+- nul terminated:</span><br><span style="color: hsl(120, 100%, 40%);">+"termi\nated"</span><br><span style="color: hsl(120, 100%, 40%);">+- passthru:</span><br><span style="color: hsl(120, 100%, 40%);">+passed through unchanged "printable"</span><br><span style="color: hsl(120, 100%, 40%);">+- zero length:</span><br><span style="color: hsl(120, 100%, 40%);">+""</span><br><span style="color: hsl(120, 100%, 40%);">+- truncation when too long:</span><br><span style="color: hsl(120, 100%, 40%);">+"\x07xxxxx"</span><br><span style="color: hsl(120, 100%, 40%);">+- Test escaping an escaped string:</span><br><span style="color: hsl(120, 100%, 40%);">+0: '\x02\x03\n'</span><br><span style="color: hsl(120, 100%, 40%);">+1: '\\x02\\x03\\n'</span><br><span style="color: hsl(120, 100%, 40%);">+2: '\\\\x02\\\\x03\\\\n'</span><br><span style="color: hsl(120, 100%, 40%);">+3: '\\\\\\\\x02\\\\\\\\x03\\\\\\\\n'</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Testing string quoting: osmo_quote_cstr_buf()</span><br><span style="color: hsl(120, 100%, 40%);">+- all chars from 0 to 255 in batches of 16:</span><br><span style="color: hsl(120, 100%, 40%);">+"\0\x01\x02\x03\x04\x05\x06\x07\x08\t\n\x0b\x0c\r\x0e\x0f"</span><br><span style="color: hsl(120, 100%, 40%);">+"\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1a\x1b\x1c\x1d\x1e\x1f"</span><br><span style="color: hsl(120, 100%, 40%);">+" !\"#$%&'()*+,-./"</span><br><span style="color: hsl(120, 100%, 40%);">+"0123456789:;<=>?"</span><br><span style="color: hsl(120, 100%, 40%);">+"@ABCDEFGHIJKLMNO"</span><br><span style="color: hsl(120, 100%, 40%);">+"PQRSTUVWXYZ[\\]^_"</span><br><span style="color: hsl(120, 100%, 40%);">+"`abcdefghijklmno"</span><br><span style="color: hsl(120, 100%, 40%);">+"pqrstuvwxyz{|}~\x7f"</span><br><span style="color: hsl(120, 100%, 40%);">+"\x80\x81\x82\x83\x84\x85\x86\x87\x88\x89\x8a\x8b\x8c\x8d\x8e\x8f"</span><br><span style="color: hsl(120, 100%, 40%);">+"\x90\x91\x92\x93\x94\x95\x96\x97\x98\x99\x9a\x9b\x9c\x9d\x9e\x9f"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xa0\xa1\xa2\xa3\xa4\xa5\xa6\xa7\xa8\xa9\xaa\xab\xac\xad\xae\xaf"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xb0\xb1\xb2\xb3\xb4\xb5\xb6\xb7\xb8\xb9\xba\xbb\xbc\xbd\xbe\xbf"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xc0\xc1\xc2\xc3\xc4\xc5\xc6\xc7\xc8\xc9\xca\xcb\xcc\xcd\xce\xcf"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xd0\xd1\xd2\xd3\xd4\xd5\xd6\xd7\xd8\xd9\xda\xdb\xdc\xdd\xde\xdf"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xe0\xe1\xe2\xe3\xe4\xe5\xe6\xe7\xe8\xe9\xea\xeb\xec\xed\xee\xef"</span><br><span style="color: hsl(120, 100%, 40%);">+"\xf0\xf1\xf2\xf3\xf4\xf5\xf6\xf7\xf8\xf9\xfa\xfb\xfc\xfd\xfe\xff"</span><br><span style="color: hsl(120, 100%, 40%);">+- nul terminated:</span><br><span style="color: hsl(120, 100%, 40%);">+'"termi\nated"'</span><br><span style="color: hsl(120, 100%, 40%);">+- never passthru:</span><br><span style="color: hsl(120, 100%, 40%);">+NOT passed through. '"printable"'</span><br><span style="color: hsl(120, 100%, 40%);">+- zero length:</span><br><span style="color: hsl(120, 100%, 40%);">+'""'</span><br><span style="color: hsl(120, 100%, 40%);">+- truncation when too long:</span><br><span style="color: hsl(120, 100%, 40%);">+'"\x07xxxx'</span><br><span style="color: hsl(120, 100%, 40%);">+- always truncation, even when no escaping needed:</span><br><span style="color: hsl(120, 100%, 40%);">+'"xxxxxxxE'</span><br><span style="color: hsl(120, 100%, 40%);">+- try to feed too little buf for quoting:</span><br><span style="color: hsl(120, 100%, 40%);">+'"'</span><br><span style="color: hsl(120, 100%, 40%);">+- Test quoting a quoted+escaped string:</span><br><span style="color: hsl(120, 100%, 40%);">+0: "\x02\x03\n"</span><br><span style="color: hsl(120, 100%, 40%);">+1: "\"\\x02\\x03\\n\""</span><br><span style="color: hsl(120, 100%, 40%);">+2: "\"\\\"\\\\x02\\\\x03\\\\n\\\"\""</span><br><span style="color: hsl(120, 100%, 40%);">+3: "\"\\\"\\\\\\\"\\\\\\\\x02\\\\\\\\x03\\\\\\\\n\\\\\\\"\\\"\""</span><br><span style="color: hsl(120, 100%, 40%);">+- Test C-string equivalence:</span><br><span style="color: hsl(120, 100%, 40%);">+strcmp(OSMO_STRINGIFY_VAL(TEST_STR), osmo_quote_cstr_c(ctx, TEST_STR, 256)) == 0</span><br><span style="color: hsl(120, 100%, 40%);">+strcmp(OSMO_STRINGIFY_VAL(EMPTY_STR), osmo_quote_cstr_c(ctx, EMPTY_STR, -1)) == 0</span><br><span style="color: hsl(120, 100%, 40%);">+strcmp("NULL", osmo_quote_cstr_c(ctx, NULL, -1)) == 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> Testing integer square-root</span><br><span> </span><br><span> osmo_sockaddr_to_str_and_uint_test</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16160">change 16160</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16160"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3dfb892036e01000033dd8e7e4a6a0c32a3caa9b </div>
<div style="display:none"> Gerrit-Change-Number: 16160 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>