<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064/1/ttcn3-bsc-test/jenkins-sccplite.sh">File ttcn3-bsc-test/jenkins-sccplite.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064/1/ttcn3-bsc-test/jenkins-sccplite.sh@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace">2</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be 12 instead of 2</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064/1/ttcn3-bsc-test/jenkins.sh">File ttcn3-bsc-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064/1/ttcn3-bsc-test/jenkins.sh@44">Patch Set #1, Line 44:</a> <code style="font-family:monospace,monospace">                     /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-omldummy 172.18.2.20 $((i + 1234)) 1 >>/data/osmo-bts-omldummy-${i}.log 2>&1"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If osmo-bts-omldummy is not able to parse the config, it will print a short error and then respawn.sh will restart it right away, infinitely. This probably causes slaves to run out of disk space fast.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe add a commit, that limits the restart times in these respawn.sh scripts to a sane number(100 or 1000?), and displays the count?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064/1/ttcn3-remsim-test/jenkins.sh">File ttcn3-remsim-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064/1/ttcn3-remsim-test/jenkins.sh@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace">client</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">server</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064/1/ttcn3-sip-test/jenkins.sh">File ttcn3-sip-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/16064/1/ttcn3-sip-test/jenkins.sh@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace">          osmo-sip-connector</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this line must be deleted</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/16064">change 16064</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/16064"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3d9f6de638dbc07391a32c6a0cbd469dc5adf2b5 </div>
<div style="display:none"> Gerrit-Change-Number: 16064 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 19 Nov 2019 11:44:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>