<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16094">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm.c: replace magic numbers with NM_CHANC_* constants<br><br>Change-Id: I60b20d617bd8710a95977e41ae32a431af4402a9<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/16094/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 572d762..ca0df68 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -1804,8 +1804,8 @@</span><br><span>                   /* not on the same TRX that has a BCCH+SDCCH4</span><br><span>                         * combination */</span><br><span>                    if (ts->trx != ts->trx->bts->c0 &&</span><br><span style="color: hsl(0, 100%, 40%);">-                      (ts->trx->ts[0].nm_chan_comb == 5 ||</span><br><span style="color: hsl(0, 100%, 40%);">-                       ts->trx->ts[0].nm_chan_comb == 8)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                           (ts->trx->ts[0].nm_chan_comb == NM_CHANC_BCCHComb ||</span><br><span style="color: hsl(120, 100%, 40%);">+                             ts->trx->ts[0].nm_chan_comb == NM_CHANC_SDCCH_CBCH)) {</span><br><span>                            *reason = "SDCCH/8 and BCCH must be on the same TRX.";</span><br><span>                             return -EINVAL;</span><br><span>                      }</span><br><span>@@ -1829,7 +1829,7 @@</span><br><span>                            return -EINVAL;</span><br><span>                      }</span><br><span>                    break;</span><br><span style="color: hsl(0, 100%, 40%);">-          case 8: /* this is not like 08.58, but in fact</span><br><span style="color: hsl(120, 100%, 40%);">+                case NM_CHANC_SDCCH_CBCH: /* this is not like 08.58, but in fact</span><br><span>                      * FCCH+SCH+BCCH+CCCH+SDCCH/4+SACCH/C4+CBCH */</span><br><span>                       /* FIXME: only one CBCH allowed per cell */</span><br><span>                  break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16094">change 16094</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/16094"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I60b20d617bd8710a95977e41ae32a431af4402a9 </div>
<div style="display:none"> Gerrit-Change-Number: 16094 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>