<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/16092">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/fake_trx.py: send NOPE.ind in case of path loss simulation<br><br>Since TRXD header version 1, we should send NOPE indications to the<br>L1 side in absence of TRX2L1 bursts, and IDLE indications during<br>IDLE TDMA frames (basically noise measurements).<br><br>This change is the first step towards the goal: if a given burst<br>is to be dropped due to the path loss simulation (see FAKE_DROP),<br>mark the carrier TRX2L1 message as NOPE.ind and send anyway.<br><br>Change-Id: Iabd0af665e3108d23a908638f943a5b689986e2c<br>Related: OS#3428, OS#2975<br>---<br>M src/target/trx_toolkit/fake_trx.py<br>1 file changed, 27 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/16092/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py</span><br><span>index 5153722..50111bf 100755</span><br><span>--- a/src/target/trx_toolkit/fake_trx.py</span><br><span>+++ b/src/target/trx_toolkit/fake_trx.py</span><br><span>@@ -4,7 +4,7 @@</span><br><span> # TRX Toolkit</span><br><span> # Virtual Um-interface (fake transceiver)</span><br><span> #</span><br><span style="color: hsl(0, 100%, 40%);">-# (C) 2017-2018 by Vadim Yanitskiy <axilirator@gmail.com></span><br><span style="color: hsl(120, 100%, 40%);">+# (C) 2017-2019 by Vadim Yanitskiy <axilirator@gmail.com></span><br><span> #</span><br><span> # All Rights Reserved</span><br><span> #</span><br><span>@@ -22,7 +22,7 @@</span><br><span> # with this program; if not, write to the Free Software Foundation, Inc.,</span><br><span> # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-APP_CR_HOLDERS = [("2017-2018", "Vadim Yanitskiy <axilirator@gmail.com>")]</span><br><span style="color: hsl(120, 100%, 40%);">+APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy <axilirator@gmail.com>")]</span><br><span> </span><br><span> import logging as log</span><br><span> import signal</span><br><span>@@ -110,6 +110,11 @@</span><br><span> RSSI_BASE_DEFAULT = -60</span><br><span> CI_BASE_DEFAULT = 90</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ # Default values for NOPE / IDLE indications</span><br><span style="color: hsl(120, 100%, 40%);">+ TOA256_NOISE_DEFAULT = 0</span><br><span style="color: hsl(120, 100%, 40%);">+ RSSI_NOISE_DEFAULT = -110</span><br><span style="color: hsl(120, 100%, 40%);">+ CI_NOISE_DEFAULT = -30</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> def __init__(self, *trx_args, **trx_kwargs):</span><br><span> Transceiver.__init__(self, *trx_args, **trx_kwargs)</span><br><span> </span><br><span>@@ -177,9 +182,6 @@</span><br><span> return False</span><br><span> </span><br><span> def _handle_data_msg_v1(self, src_msg, msg):</span><br><span style="color: hsl(0, 100%, 40%);">- # TODO: NOPE indications are not (yet) supported</span><br><span style="color: hsl(0, 100%, 40%);">- msg.nope_ind = False</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> # C/I (Carrier-to-Interference ratio)</span><br><span> msg.ci = self.ci</span><br><span> </span><br><span>@@ -200,6 +202,26 @@</span><br><span> # simulates RF path parameters (such as RSSI),</span><br><span> # and sends towards the L1</span><br><span> def handle_data_msg(self, src_trx, src_msg, msg):</span><br><span style="color: hsl(120, 100%, 40%);">+ # Path loss simulation</span><br><span style="color: hsl(120, 100%, 40%);">+ msg.nope_ind = self.sim_burst_drop(msg)</span><br><span style="color: hsl(120, 100%, 40%);">+ if msg.nope_ind:</span><br><span style="color: hsl(120, 100%, 40%);">+ # Before TRXDv1, we simply drop the message</span><br><span style="color: hsl(120, 100%, 40%);">+ if msg.ver < 0x01:</span><br><span style="color: hsl(120, 100%, 40%);">+ del msg</span><br><span style="color: hsl(120, 100%, 40%);">+ return</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ # Since TRXDv1, we should send a NOPE.ind</span><br><span style="color: hsl(120, 100%, 40%);">+ del msg.burst # burst bits are omited</span><br><span style="color: hsl(120, 100%, 40%);">+ msg.burst = None</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ # TODO: shoud we make these values configurable?</span><br><span style="color: hsl(120, 100%, 40%);">+ msg.toa256 = self.TOA256_NOISE_DEFAULT</span><br><span style="color: hsl(120, 100%, 40%);">+ msg.rssi = self.RSSI_NOISE_DEFAULT</span><br><span style="color: hsl(120, 100%, 40%);">+ msg.ci = self.CI_NOISE_DEFAULT</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ self.data_if.send_msg(msg)</span><br><span style="color: hsl(120, 100%, 40%);">+ return</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Complete message header</span><br><span> msg.toa256 = self.toa256</span><br><span> msg.rssi = self.rssi</span><br><span>@@ -212,10 +234,6 @@</span><br><span> if src_trx.ta is not 0:</span><br><span> msg.toa256 -= src_trx.ta * 256</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- # Path loss simulation</span><br><span style="color: hsl(0, 100%, 40%);">- if self.sim_burst_drop(msg):</span><br><span style="color: hsl(0, 100%, 40%);">- return</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> # TODO: make legacy mode configurable (via argv?)</span><br><span> self.data_if.send_msg(msg, legacy = True)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/16092">change 16092</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/16092"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iabd0af665e3108d23a908638f943a5b689986e2c </div>
<div style="display:none"> Gerrit-Change-Number: 16092 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>