<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/16067">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">scheduler_trx.c: avoid division by zero when calculating BER<br><br>There is theoretical risk that when calculating the BER that a division<br>by zero occurrs. Lets add a check to avoid n_errors / n_bits_total when<br>n_bits_total is zero.<br><br>Related: CID#205696<br>Change-Id: I1c0731b9a60be4b8c0c84b85b4403168120ceacd<br>---<br>M src/osmo-bts-trx/scheduler_trx.c<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/67/16067/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>index 9945b2c..0f1b233 100644</span><br><span>--- a/src/osmo-bts-trx/scheduler_trx.c</span><br><span>+++ b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>@@ -1149,6 +1149,7 @@</span><br><span>        struct gsm_lchan *lchan =</span><br><span>            get_lchan_by_chan_nr(l1t->trx, trx_chan_desc[chan].chan_nr | bi->tn);</span><br><span>  unsigned int fn_begin;</span><br><span style="color: hsl(120, 100%, 40%);">+        float ber;</span><br><span> </span><br><span>       /* handle rach, if handover rach detection is turned on */</span><br><span>   if (chan_state->ho_rach_detect == 1)</span><br><span>@@ -1212,10 +1213,12 @@</span><br><span>                    (((bi->fn + 26 - 7) % 26) >> 2) & 1, chan_state->codec,</span><br><span>                      chan_state->codecs, &chan_state->ul_ft,</span><br><span>                    &chan_state->ul_cmr, &n_errors, &n_bits_total);</span><br><span style="color: hsl(120, 100%, 40%);">+                if (n_bits_total == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                        ber = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+              else</span><br><span style="color: hsl(120, 100%, 40%);">+                  ber = (float)n_errors / (float)n_bits_total;</span><br><span>                 if (rc)</span><br><span style="color: hsl(0, 100%, 40%);">-                 trx_loop_amr_input(l1t,</span><br><span style="color: hsl(0, 100%, 40%);">-                         trx_chan_desc[chan].chan_nr | bi->tn, chan_state,</span><br><span style="color: hsl(0, 100%, 40%);">-                            (float)n_errors/(float)n_bits_total);</span><br><span style="color: hsl(120, 100%, 40%);">+                 trx_loop_amr_input(l1t, trx_chan_desc[chan].chan_nr | bi->tn, chan_state, ber);</span><br><span>           amr = 2; /* we store tch_data + 2 header bytes */</span><br><span>            /* only good speech frames get rtp header */</span><br><span>                 if (rc != GSM_MACBLOCK_LEN && rc >= 4) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/16067">change 16067</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/16067"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1c0731b9a60be4b8c0c84b85b4403168120ceacd </div>
<div style="display:none"> Gerrit-Change-Number: 16067 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>