<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16035">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Hoernchen: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ccid_device: Fix memory leaks in ccid_handle_out() error paths<br><br>Change-Id: I7c5e916992a7b55ca1ab006759c1f5c62b759d57<br>---<br>M ccid_common/ccid_device.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid_common/ccid_device.c b/ccid_common/ccid_device.c</span><br><span>index 049b1cf..8183b16 100644</span><br><span>--- a/ccid_common/ccid_device.c</span><br><span>+++ b/ccid_common/ccid_device.c</span><br><span>@@ -644,6 +644,7 @@</span><br><span> </span><br><span>        if (len < sizeof(*ch)) {</span><br><span>          /* FIXME */</span><br><span style="color: hsl(120, 100%, 40%);">+           msgb_free(msg);</span><br><span>              return -1;</span><br><span>   }</span><br><span> </span><br><span>@@ -652,6 +653,7 @@</span><br><span>  if (!cs) {</span><br><span>           LOGPCI(ci, LOGL_ERROR, "Invalid bSlot %u\n", ch->bSlot);</span><br><span>                resp = gen_err_resp(ch->bMessageType, ch->bSlot, CCID_ICC_STATUS_NO_ICC, ch->bSeq, 5);</span><br><span style="color: hsl(120, 100%, 40%);">+               msgb_free(msg);</span><br><span>              return ccid_send(ci, resp);</span><br><span>  }</span><br><span> </span><br><span>@@ -661,6 +663,7 @@</span><br><span>          /* FIXME: ABORT logic as per section 5.3.1 of CCID Spec v1.1 */</span><br><span>              resp = gen_err_resp(ch->bMessageType, ch->bSlot, get_icc_status(cs), ch->bSeq,</span><br><span>                                      CCID_ERR_CMD_SLOT_BUSY);</span><br><span style="color: hsl(120, 100%, 40%);">+              msgb_free(msg);</span><br><span>              return ccid_send(ci, resp);</span><br><span>  }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16035">change 16035</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16035"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7c5e916992a7b55ca1ab006759c1f5c62b759d57 </div>
<div style="display:none"> Gerrit-Change-Number: 16035 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>