<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16055">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Hoernchen: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Avoid endless loop while printing debug uart ringbuffer<br><br>Change-Id: I84bf6f47c785cfecec4764f7e86958103cf24f8a<br>---<br>M sysmoOCTSIM/hal/src/hal_usart_async_rings.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sysmoOCTSIM/hal/src/hal_usart_async_rings.c b/sysmoOCTSIM/hal/src/hal_usart_async_rings.c</span><br><span>index 38bdca4..704c6ab 100644</span><br><span>--- a/sysmoOCTSIM/hal/src/hal_usart_async_rings.c</span><br><span>+++ b/sysmoOCTSIM/hal/src/hal_usart_async_rings.c</span><br><span>@@ -321,7 +321,11 @@</span><br><span>         ASSERT(descr && buf && length);</span><br><span> </span><br><span>  for (uint16_t i = 0; i < length; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-              while (ringbuffer_num(&descr->tx) > descr->tx.size); // WARNING blocking until there is space in the buffer</span><br><span style="color: hsl(120, 100%, 40%);">+              /* HACK: disabling this to avoid getting stuck indefinitely.  In theory, this while loop below</span><br><span style="color: hsl(120, 100%, 40%);">+                 * would exit at some point as the UART is supposedly transmitting data.  However, in some</span><br><span style="color: hsl(120, 100%, 40%);">+             * situations it is not transmitting, and hence the condition becomes never true, waiting here</span><br><span style="color: hsl(120, 100%, 40%);">+                 * indefinitely.  We will now simply ovewrite old log data if it isn't sent fast enough */</span><br><span style="color: hsl(120, 100%, 40%);">+                //while (ringbuffer_num(&descr->tx) > descr->tx.size); // WARNING blocking until there is space in the buffer</span><br><span>           ringbuffer_put(&descr->tx, buf[i]);</span><br><span>   }</span><br><span>    descr->stat             = USART_ASYNC_RINGS_STATUS_BUSY;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16055">change 16055</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16055"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I84bf6f47c785cfecec4764f7e86958103cf24f8a </div>
<div style="display:none"> Gerrit-Change-Number: 16055 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>