<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16048">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/db_upgrade: disable for old sqlite versions<br><br>Skip the test if the installed sqlite version is older than 3.16.2<br>(current version of debian 9). This prevents test failures caused by<br>the way we dump tables in the test, which does not work with older<br>versions.<br><br>This patch is a middle ground between reverting the db upgrade patch,<br>and spending lots of time to replace the table dumping code with<br>something that works with old sqlite versions to fix current build<br>failures in OBS.<br><br>Usually version checking is done in configure.ac, however I could not<br>find a good way to pass the result to testsuite.at. So I decided to<br>use pkg-config to do the test there.<br><br>Fixes: 5b65461d686327ead0cb2a6d8493dfa9173d376c ("add db_upgrade test")<br>Related: https://lists.osmocom.org/pipermail/openbsc/2019-November/013063.html<br>Change-Id: I348c133003a95badbd6807d1519aa669115872fb<br>---<br>M tests/testsuite.at<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/48/16048/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/testsuite.at b/tests/testsuite.at</span><br><span>index a8efe42..bd758c9 100644</span><br><span>--- a/tests/testsuite.at</span><br><span>+++ b/tests/testsuite.at</span><br><span>@@ -37,7 +37,10 @@</span><br><span> AT_CHECK([$abs_top_builddir/tests/db/db_test], [], [expout], [experr])</span><br><span> AT_CLEANUP</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+# AT_SKIP_IF: disable for old sqlite versions, because the way we dump tables in the test doesn't work with it.</span><br><span style="color: hsl(120, 100%, 40%);">+# https://lists.osmocom.org/pipermail/openbsc/2019-November/013063.html</span><br><span> AT_SETUP([db_upgrade])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_SKIP_IF([ ! pkg-config sqlite3 --exists --atleast-version=3.16.2 ])</span><br><span> AT_KEYWORDS([db_upgrade])</span><br><span> cat $abs_srcdir/db_upgrade/db_upgrade_test.ok > expout</span><br><span> cat $abs_srcdir/db_upgrade/db_upgrade_test.err > experr</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16048">change 16048</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16048"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I348c133003a95badbd6807d1519aa669115872fb </div>
<div style="display:none"> Gerrit-Change-Number: 16048 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>