<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15914">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hlr db schema 3: hlr_number -> msc_number<br><br>The osmo-hlr DB schema indicates a hlr_number column and references it as 3GPP<br>TS 23.008 chapter 2.4.6. However, chapter 2.4.6 refers to the "MSC number",<br>while the "HLR number" is chapter 2.4.7.<br><br>Taking a closer look, 2.4.6 says "The MSC number is [...] stored in the HLR",<br>while 2.4.7 says "The HLR number may be stored in the VLR". As quite obvious,<br>the HLR does not store the HLR number. This was a typo from the start.<br><br>The osmo-hlr code base so far does not use the hlr_number column at all, so we<br>get away with renaming the column without any effects on the code base.<br>However, let's rather make this a new schema version to be safe.<br><br>Change-Id: I527e8627b24b79f3e9eec32675c7f5a3a6d25440<br>---<br>M doc/manuals/chapters/subscribers.adoc<br>M sql/hlr.sql<br>M src/db.c<br>M tests/db_upgrade/db_upgrade_test.ok<br>4 files changed, 157 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/chapters/subscribers.adoc b/doc/manuals/chapters/subscribers.adoc</span><br><span>index e09e99a..ab41b0f 100644</span><br><span>--- a/doc/manuals/chapters/subscribers.adoc</span><br><span>+++ b/doc/manuals/chapters/subscribers.adoc</span><br><span>@@ -52,7 +52,7 @@</span><br><span> |aud3g.ind_bitlen|5|Nr of index bits at lower SQN end</span><br><span> |apn||</span><br><span> |vlr_number||3GPP TS 23.008 chapter 2.4.5</span><br><span style="color: hsl(0, 100%, 40%);">-|hlr_number||3GPP TS 23.008 chapter 2.4.6</span><br><span style="color: hsl(120, 100%, 40%);">+|msc_number||3GPP TS 23.008 chapter 2.4.6</span><br><span> |sgsn_number||3GPP TS 23.008 chapter 2.4.8.1</span><br><span> |sgsn_address||3GPP TS 23.008 chapter 2.13.10</span><br><span> |ggsn_number||3GPP TS 23.008 chapter 2.4.8.2</span><br><span>diff --git a/sql/hlr.sql b/sql/hlr.sql</span><br><span>index c1b0f1a..f8fdc0b 100644</span><br><span>--- a/sql/hlr.sql</span><br><span>+++ b/sql/hlr.sql</span><br><span>@@ -12,7 +12,7 @@</span><br><span> -- Chapter 2.4.5</span><br><span> vlr_number VARCHAR(15),</span><br><span> -- Chapter 2.4.6</span><br><span style="color: hsl(0, 100%, 40%);">- hlr_number VARCHAR(15),</span><br><span style="color: hsl(120, 100%, 40%);">+ msc_number VARCHAR(15),</span><br><span> -- Chapter 2.4.8.1</span><br><span> sgsn_number VARCHAR(15),</span><br><span> -- Chapter 2.13.10</span><br><span>@@ -77,4 +77,4 @@</span><br><span> </span><br><span> -- Set HLR database schema version number</span><br><span> -- Note: This constant is currently duplicated in src/db.c and must be kept in sync!</span><br><span style="color: hsl(0, 100%, 40%);">-PRAGMA user_version = 2;</span><br><span style="color: hsl(120, 100%, 40%);">+PRAGMA user_version = 3;</span><br><span>diff --git a/src/db.c b/src/db.c</span><br><span>index 31c4ba5..d2564e6 100644</span><br><span>--- a/src/db.c</span><br><span>+++ b/src/db.c</span><br><span>@@ -28,7 +28,7 @@</span><br><span> #include "db_bootstrap.h"</span><br><span> </span><br><span> /* This constant is currently duplicated in sql/hlr.sql and must be kept in sync! */</span><br><span style="color: hsl(0, 100%, 40%);">-#define CURRENT_SCHEMA_VERSION 2</span><br><span style="color: hsl(120, 100%, 40%);">+#define CURRENT_SCHEMA_VERSION 3</span><br><span> </span><br><span> #define SEL_COLUMNS \</span><br><span> "id," \</span><br><span>@@ -329,6 +329,140 @@</span><br><span> return rc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static int db_upgrade_v3(struct db_context *dbc)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ sqlite3_stmt *stmt;</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* A newer SQLite version would allow simply 'ATLER TABLE subscriber RENAME COLUMN hlr_number TO msc_number'.</span><br><span style="color: hsl(120, 100%, 40%);">+ * This is a really expensive workaround for that in order to cover earlier SQLite versions as well:</span><br><span style="color: hsl(120, 100%, 40%);">+ * Create a new table with the new column name and copy the data over (https://www.sqlite.org/faq.html#q11).</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+#define SUBSCR_V3_CREATE \</span><br><span style="color: hsl(120, 100%, 40%);">+"(\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+"-- OsmoHLR's DB scheme is modelled roughly after TS 23.008 version 13.3.0\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" id INTEGER PRIMARY KEY,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.1.1.1\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" imsi VARCHAR(15) UNIQUE NOT NULL,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.1.2\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" msisdn VARCHAR(15) UNIQUE,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.2.3: Most recent / current IMEISV\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" imeisv VARCHAR,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.1.9: Most recent / current IMEI\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" imei VARCHAR(14),\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.4.5\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" vlr_number VARCHAR(15),\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.4.6\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" msc_number VARCHAR(15),\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.4.8.1\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" sgsn_number VARCHAR(15),\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.13.10\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" sgsn_address VARCHAR,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.4.8.2\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" ggsn_number VARCHAR(15),\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.4.9.2\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" gmlc_number VARCHAR(15),\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.4.23\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" smsc_number VARCHAR(15),\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.4.24\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" periodic_lu_tmr INTEGER,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.13.115\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" periodic_rau_tau_tmr INTEGER,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.1.1.2: network access mode\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" nam_cs BOOLEAN NOT NULL DEFAULT 1,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" nam_ps BOOLEAN NOT NULL DEFAULT 1,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.1.8\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" lmsi INTEGER,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- The below purged flags might not even be stored non-volatile,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- refer to TS 23.012 Chapter 3.6.1.4\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.7.5\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" ms_purged_cs BOOLEAN NOT NULL DEFAULT 0,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Chapter 2.7.6\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" ms_purged_ps BOOLEAN NOT NULL DEFAULT 0,\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+ \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- Timestamp of last location update seen from subscriber\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" -- The value is a string which encodes a UTC timestamp in granularity of seconds.\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+" last_lu_seen TIMESTAMP default NULL\n" \</span><br><span style="color: hsl(120, 100%, 40%);">+")\n"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define SUBSCR_V2_COLUMN_NAMES \</span><br><span style="color: hsl(120, 100%, 40%);">+ "id," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "imsi," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "msisdn," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "imeisv," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "imei," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "vlr_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "hlr_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "sgsn_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "sgsn_address," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "ggsn_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "gmlc_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "smsc_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "periodic_lu_tmr," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "periodic_rau_tau_tmr," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "nam_cs," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "nam_ps," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "lmsi," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "ms_purged_cs," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "ms_purged_ps," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "last_lu_seen"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define SUBSCR_V3_COLUMN_NAMES \</span><br><span style="color: hsl(120, 100%, 40%);">+ "id," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "imsi," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "msisdn," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "imeisv," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "imei," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "vlr_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "msc_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "sgsn_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "sgsn_address," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "ggsn_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "gmlc_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "smsc_number," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "periodic_lu_tmr," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "periodic_rau_tau_tmr," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "nam_cs," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "nam_ps," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "lmsi," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "ms_purged_cs," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "ms_purged_ps," \</span><br><span style="color: hsl(120, 100%, 40%);">+ "last_lu_seen"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *statements[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ "BEGIN TRANSACTION",</span><br><span style="color: hsl(120, 100%, 40%);">+ "CREATE TEMPORARY TABLE subscriber_backup" SUBSCR_V3_CREATE,</span><br><span style="color: hsl(120, 100%, 40%);">+ "INSERT INTO subscriber_backup SELECT " SUBSCR_V2_COLUMN_NAMES " FROM subscriber",</span><br><span style="color: hsl(120, 100%, 40%);">+ "DROP TABLE subscriber",</span><br><span style="color: hsl(120, 100%, 40%);">+ "CREATE TABLE subscriber" SUBSCR_V3_CREATE,</span><br><span style="color: hsl(120, 100%, 40%);">+ "INSERT INTO subscriber SELECT " SUBSCR_V3_COLUMN_NAMES " FROM subscriber_backup",</span><br><span style="color: hsl(120, 100%, 40%);">+ "DROP TABLE subscriber_backup",</span><br><span style="color: hsl(120, 100%, 40%);">+ "COMMIT",</span><br><span style="color: hsl(120, 100%, 40%);">+ "PRAGMA user_version = 3",</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ int i;</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < ARRAY_SIZE(statements); i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *update_stmt_sql = statements[i];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = sqlite3_prepare_v2(dbc->db, update_stmt_sql, -1, &stmt, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc != SQLITE_OK) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DDB, LOGL_ERROR, "Unable to prepare SQL statement '%s'\n", update_stmt_sql);</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = sqlite3_step(stmt);</span><br><span style="color: hsl(120, 100%, 40%);">+ db_remove_reset(stmt);</span><br><span style="color: hsl(120, 100%, 40%);">+ sqlite3_finalize(stmt);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc != SQLITE_DONE) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DDB, LOGL_ERROR, "Unable to update HLR database schema to version 3\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static int db_get_user_version(struct db_context *dbc)</span><br><span> {</span><br><span> const char *user_version_sql = "PRAGMA user_version";</span><br><span>@@ -459,6 +593,15 @@</span><br><span> }</span><br><span> version = 2;</span><br><span> /* fall through */</span><br><span style="color: hsl(120, 100%, 40%);">+ case 2:</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = db_upgrade_v3(dbc);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc != SQLITE_DONE) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DDB, LOGL_ERROR, "Failed to upgrade HLR DB schema to version 3: (rc=%d) %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ rc, sqlite3_errmsg(dbc->db));</span><br><span style="color: hsl(120, 100%, 40%);">+ goto out_free;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ version = 3;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* fall through */</span><br><span> /* case N: ... */</span><br><span> default:</span><br><span> break;</span><br><span>diff --git a/tests/db_upgrade/db_upgrade_test.ok b/tests/db_upgrade/db_upgrade_test.ok</span><br><span>index bce3eb4..c1f0f9d 100644</span><br><span>--- a/tests/db_upgrade/db_upgrade_test.ok</span><br><span>+++ b/tests/db_upgrade/db_upgrade_test.ok</span><br><span>@@ -80,7 +80,7 @@</span><br><span> DMAIN hlr starting</span><br><span> DDB using database: <PATH>test.db</span><br><span> DDB Database <PATH>test.db' has HLR DB schema version 0</span><br><span style="color: hsl(0, 100%, 40%);">-DDB Database <PATH>test.db' has been upgraded to HLR DB schema version 2</span><br><span style="color: hsl(120, 100%, 40%);">+DDB Database <PATH>test.db' has been upgraded to HLR DB schema version 3</span><br><span> DMAIN Cmdline option --db-check: Database was opened successfully, quitting.</span><br><span> </span><br><span> Resulting db:</span><br><span>@@ -117,7 +117,6 @@</span><br><span> name|type|notnull|dflt_value|pk</span><br><span> ggsn_number|VARCHAR(15)|0||0</span><br><span> gmlc_number|VARCHAR(15)|0||0</span><br><span style="color: hsl(0, 100%, 40%);">-hlr_number|VARCHAR(15)|0||0</span><br><span> id|INTEGER|0||1</span><br><span> imei|VARCHAR(14)|0||0</span><br><span> imeisv|VARCHAR|0||0</span><br><span>@@ -126,6 +125,7 @@</span><br><span> lmsi|INTEGER|0||0</span><br><span> ms_purged_cs|BOOLEAN|1|0|0</span><br><span> ms_purged_ps|BOOLEAN|1|0|0</span><br><span style="color: hsl(120, 100%, 40%);">+msc_number|VARCHAR(15)|0||0</span><br><span> msisdn|VARCHAR(15)|0||0</span><br><span> nam_cs|BOOLEAN|1|1|0</span><br><span> nam_ps|BOOLEAN|1|1|0</span><br><span>@@ -137,13 +137,13 @@</span><br><span> vlr_number|VARCHAR(15)|0||0</span><br><span> </span><br><span> Table subscriber contents:</span><br><span style="color: hsl(0, 100%, 40%);">-ggsn_number|gmlc_number|hlr_number|id|imei|imeisv|imsi|last_lu_seen|lmsi|ms_purged_cs|ms_purged_ps|msisdn|nam_cs|nam_ps|periodic_lu_tmr|periodic_rau_tau_tmr|sgsn_address|sgsn_number|smsc_number|vlr_number</span><br><span style="color: hsl(0, 100%, 40%);">-|||1|||123456789012345|||0|0|098765432109876|1|1||||||MSC-1</span><br><span style="color: hsl(0, 100%, 40%);">-|||2|||111111111|||1|0||1|1||||||</span><br><span style="color: hsl(0, 100%, 40%);">-|||3|||222222222|||0|1|22222|1|1||||||</span><br><span style="color: hsl(0, 100%, 40%);">-|||4|||333333|||0|0|3|0|1||||||</span><br><span style="color: hsl(0, 100%, 40%);">-|||5|||444444444444444|||0|0|4444|1|0||||||</span><br><span style="color: hsl(0, 100%, 40%);">-|||6|||5555555|||0|0|55555555555555|0|0||||||</span><br><span style="color: hsl(120, 100%, 40%);">+ggsn_number|gmlc_number|id|imei|imeisv|imsi|last_lu_seen|lmsi|ms_purged_cs|ms_purged_ps|msc_number|msisdn|nam_cs|nam_ps|periodic_lu_tmr|periodic_rau_tau_tmr|sgsn_address|sgsn_number|smsc_number|vlr_number</span><br><span style="color: hsl(120, 100%, 40%);">+||1|||123456789012345|||0|0||098765432109876|1|1||||||MSC-1</span><br><span style="color: hsl(120, 100%, 40%);">+||2|||111111111|||1|0|||1|1||||||</span><br><span style="color: hsl(120, 100%, 40%);">+||3|||222222222|||0|1||22222|1|1||||||</span><br><span style="color: hsl(120, 100%, 40%);">+||4|||333333|||0|0||3|0|1||||||</span><br><span style="color: hsl(120, 100%, 40%);">+||5|||444444444444444|||0|0||4444|1|0||||||</span><br><span style="color: hsl(120, 100%, 40%);">+||6|||5555555|||0|0||55555555555555|0|0||||||</span><br><span> </span><br><span> Table: subscriber_apn</span><br><span> name|type|notnull|dflt_value|pk</span><br><span>@@ -164,5 +164,5 @@</span><br><span> rc = 0</span><br><span> DMAIN hlr starting</span><br><span> DDB using database: <PATH>test.db</span><br><span style="color: hsl(0, 100%, 40%);">-DDB Database <PATH>test.db' has HLR DB schema version 2</span><br><span style="color: hsl(120, 100%, 40%);">+DDB Database <PATH>test.db' has HLR DB schema version 3</span><br><span> DMAIN Cmdline option --db-check: Database was opened successfully, quitting.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15914">change 15914</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/15914"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I527e8627b24b79f3e9eec32675c7f5a3a6d25440 </div>
<div style="display:none"> Gerrit-Change-Number: 15914 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>