<p>dexter <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/15908">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  dexter: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">scheduler_trx: initalize n_errors, n_bursts_bits, n_bits_total<br><br>Make sure the variables n_errors, n_bursts_bits, n_bits_total are always<br>initalized. For example in rx_tchh_fn() the value for n_errors is<br>defined in a switch statement, where the default lets n_errors<br>uninitalized, which is in that particular case a theoretical problem,<br>however, lets make sure that the variables n_errors, n_bursts_bits and<br>n_bits_total are always initalized with 0<br><br>Related: CID#205452<br>Related: CID#205451<br>Change-Id: If28ea11cc111c7d73ca47b25e65ce399e5baa4c1<br>---<br>M src/osmo-bts-trx/scheduler_trx.c<br>1 file changed, 11 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>index 88e4f3a..9945b2c 100644</span><br><span>--- a/src/osmo-bts-trx/scheduler_trx.c</span><br><span>+++ b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>@@ -783,7 +783,8 @@</span><br><span>            uint8_t bid, const struct trx_ul_burst_ind *bi)</span><br><span> {</span><br><span>  struct osmo_phsap_prim l1sap;</span><br><span style="color: hsl(0, 100%, 40%);">-   int n_errors, n_bits_total;</span><br><span style="color: hsl(120, 100%, 40%);">+   int n_errors = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     int n_bits_total = 0;</span><br><span>        uint16_t ra11;</span><br><span>       uint8_t ra;</span><br><span>  int rc;</span><br><span>@@ -904,7 +905,8 @@</span><br><span>        int32_t *ci_cb_sum = &chan_state->ci_cb_sum;</span><br><span>  uint8_t *ci_cb_num = &chan_state->ci_cb_num;</span><br><span>  uint8_t l2[GSM_MACBLOCK_LEN], l2_len;</span><br><span style="color: hsl(0, 100%, 40%);">-   int n_errors, n_bits_total;</span><br><span style="color: hsl(120, 100%, 40%);">+   int n_errors = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     int n_bits_total = 0;</span><br><span>        int16_t lqual_cb;</span><br><span>    uint16_t ber10k;</span><br><span>     int rc;</span><br><span>@@ -1020,7 +1022,9 @@</span><br><span>      int32_t *ci_cb_sum = &chan_state->ci_cb_sum;</span><br><span>  uint8_t *ci_cb_num = &chan_state->ci_cb_num;</span><br><span>  uint8_t l2[EGPRS_0503_MAX_BYTES];</span><br><span style="color: hsl(0, 100%, 40%);">-       int n_errors, n_bursts_bits, n_bits_total;</span><br><span style="color: hsl(120, 100%, 40%);">+    int n_errors = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     int n_bursts_bits = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+        int n_bits_total = 0;</span><br><span>        int16_t lqual_cb;</span><br><span>    uint16_t ber10k;</span><br><span>     int rc;</span><br><span>@@ -1139,7 +1143,8 @@</span><br><span>      uint8_t tch_mode = chan_state->tch_mode;</span><br><span>  uint8_t tch_data[128]; /* just to be safe */</span><br><span>         int rc, amr = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-        int n_errors, n_bits_total;</span><br><span style="color: hsl(120, 100%, 40%);">+   int n_errors = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     int n_bits_total = 0;</span><br><span>        bool bfi_flag = false;</span><br><span>       struct gsm_lchan *lchan =</span><br><span>            get_lchan_by_chan_nr(l1t->trx, trx_chan_desc[chan].chan_nr | bi->tn);</span><br><span>@@ -1335,7 +1340,8 @@</span><br><span>  uint8_t tch_mode = chan_state->tch_mode;</span><br><span>  uint8_t tch_data[128]; /* just to be safe */</span><br><span>         int rc, amr = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-        int n_errors, n_bits_total;</span><br><span style="color: hsl(120, 100%, 40%);">+   int n_errors = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     int n_bits_total = 0;</span><br><span>        bool bfi_flag = false;</span><br><span>       struct gsm_lchan *lchan =</span><br><span>            get_lchan_by_chan_nr(l1t->trx, trx_chan_desc[chan].chan_nr | bi->tn);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/15908">change 15908</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/15908"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If28ea11cc111c7d73ca47b25e65ce399e5baa4c1 </div>
<div style="display:none"> Gerrit-Change-Number: 15908 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>