<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/15962">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cc trans: remove unused tch_rtp_create<br><br>Use of this flag was dropped when adding inter-BSC and inter-MSC Handover<br>support, I forgot to remove it.<br><br>Change-Id: I5ec78e30eb36fbe78a3f7c46bfa44af5a4eb7bf2<br>---<br>M include/osmocom/msc/transaction.h<br>M src/libmsc/gsm_04_08_cc.c<br>2 files changed, 0 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/transaction.h b/include/osmocom/msc/transaction.h</span><br><span>index 61d8c1a..928b137 100644</span><br><span>--- a/include/osmocom/msc/transaction.h</span><br><span>+++ b/include/osmocom/msc/transaction.h</span><br><span>@@ -87,10 +87,6 @@</span><br><span>        /* bearer capabilities (rate and codec) */</span><br><span>   struct gsm_mncc_bearer_cap bearer_cap;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      /* if true, TCH_RTP_CREATE is sent after the</span><br><span style="color: hsl(0, 100%, 40%);">-     * assignment is done */</span><br><span style="color: hsl(0, 100%, 40%);">-        bool tch_rtp_create;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         union {</span><br><span>              struct {</span><br><span> </span><br><span>diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c</span><br><span>index 792ab61..7e2d70b 100644</span><br><span>--- a/src/libmsc/gsm_04_08_cc.c</span><br><span>+++ b/src/libmsc/gsm_04_08_cc.c</span><br><span>@@ -1655,20 +1655,6 @@</span><br><span>       }</span><br><span>    LOG_TRANS_CAT(trans, DMNCC, LOGL_DEBUG, "rx %s\n", get_mncc_name(MNCC_RTP_CREATE));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       /* When we call msc_mgcp_call_assignment() we will trigger, depending</span><br><span style="color: hsl(0, 100%, 40%);">-    * on the RAN type the call assignment on the A or Iu interface.</span><br><span style="color: hsl(0, 100%, 40%);">-         * msc_mgcp_call_assignment() also takes care about sending the CRCX</span><br><span style="color: hsl(0, 100%, 40%);">-     * command to the MGCP-GW. The CRCX will return the port number,</span><br><span style="color: hsl(0, 100%, 40%);">-         * where the PBX (e.g. Asterisk) will send its RTP stream to. We</span><br><span style="color: hsl(0, 100%, 40%);">-         * have to return this port number back to the MNCC by sending</span><br><span style="color: hsl(0, 100%, 40%);">-   * it back with the TCH_RTP_CREATE message. To make sure that</span><br><span style="color: hsl(0, 100%, 40%);">-    * this message is sent AFTER the response to CRCX from the</span><br><span style="color: hsl(0, 100%, 40%);">-      * MGCP-GW has arrived, we need will instruct msc_mgcp_call_assignment()</span><br><span style="color: hsl(0, 100%, 40%);">-         * to take care of this by setting trans->tch_rtp_create to true.</span><br><span style="color: hsl(0, 100%, 40%);">-     * This will make sure that gsm48_tch_rtp_create() (below) is</span><br><span style="color: hsl(0, 100%, 40%);">-    * called as soon as the local port number has become known. */</span><br><span style="color: hsl(0, 100%, 40%);">- trans->tch_rtp_create = true;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     /* Assign call (if not done yet) */</span><br><span>  return msc_a_try_call_assignment(trans);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/15962">change 15962</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/15962"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5ec78e30eb36fbe78a3f7c46bfa44af5a4eb7bf2 </div>
<div style="display:none"> Gerrit-Change-Number: 15962 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>