<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hlr: stop on various failures<br><br>I found some of the tests hard to analyse when geting failures, because they<br>don't stop the test on failure. Spread some 'mtc.stop' so that the test stops<br>at the failed message instead of carrying on.<br><br>Change-Id: I804aca84d0ccf4767a5c097cf6c882ccbd87c4e1<br>---<br>M hlr/HLR_Tests.ttcn<br>1 file changed, 15 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/16020/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn</span><br><span>index f309575..f8d7483 100644</span><br><span>--- a/hlr/HLR_Tests.ttcn</span><br><span>+++ b/hlr/HLR_Tests.ttcn</span><br><span>@@ -425,15 +425,19 @@</span><br><span> }</span><br><span> [exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, ?)) -> value ret {</span><br><span> setverdict(fail, "Unexpected UL ERROR Cause");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [exp_fail] GSUP.receive(tr_GSUP_UL_RES(imsi)) -> value ret {</span><br><span> setverdict(fail, "Unexpected UL.res for unknown IMSI");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [exp_fail] GSUP.receive(tr_GSUP_ISD_REQ(imsi)) -> value ret {</span><br><span> setverdict(fail, "Unexpected ISD.req in error case");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [not exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, ?)) -> value ret {</span><br><span> setverdict(fail, "Unexpected UL ERROR");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [not exp_fail and not isd_done] GSUP.receive(tr_GSUP_ISD_REQ(imsi, msisdn)) -> value ret {</span><br><span> GSUP.send(ts_GSUP_ISD_RES(imsi));</span><br><span>@@ -540,12 +544,14 @@</span><br><span> alt {</span><br><span> [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value ret {</span><br><span> setverdict(fail, "Unexpected PROC_SS ERROR Cause");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [not exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit)) -> value ret {</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> [exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit)) -> value ret {</span><br><span> setverdict(fail, "Unexpected PROC_SS.res without SS IE");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> /*</span><br><span> [exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, decmatch facility)) -> value ret {</span><br><span>@@ -562,9 +568,13 @@</span><br><span> setverdict(pass);</span><br><span> } else {</span><br><span> setverdict(fail, "Unexpected PROC_SS.res with non-matching facility IE");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- [] GSUP.receive { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected GSUP");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> [] T.timeout {</span><br><span> setverdict(fail, "Timeout waiting for PROC_SS response");</span><br><span> self.stop;</span><br><span>@@ -593,18 +603,22 @@</span><br><span> }</span><br><span> [exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_ERR(imsi, ?)) -> value pdu {</span><br><span> setverdict(fail, "Unexpected CHECK IMEI ERROR Cause: ", pdu);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_RES(imsi, ?)) -> value pdu {</span><br><span> setverdict(fail, "Unexpected CHECK IMEI RES instead of ERR");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [not exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_ERR(imsi, ?)) -> value pdu {</span><br><span> setverdict(fail, "Unexpected CHECK IMEI ERROR");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [not exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_RES(imsi, result)) -> value pdu {</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> [not exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_RES(imsi, ?)) -> value pdu {</span><br><span> setverdict(fail, "Unexpected CHECK IMEI RES");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span> }</span><br><span> [] GSUP.receive { repeat; }</span><br><span> [] T.timeout {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020">change 16020</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I804aca84d0ccf4767a5c097cf6c882ccbd87c4e1 </div>
<div style="display:none"> Gerrit-Change-Number: 16020 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>