<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16017">View Change</a></p><div style="white-space:pre-wrap">Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">GPRS/BSSGP: introduce bssgp_bvc_ctx_free()<br><br>So far we had a function to allocate a new bssgp_bvc_ctx, but not<br>the opposite one. Let's finally introduce it, so it will be used<br>at least in OsmoPCU.<br><br>Please note that the new symbol has 'bssgp_' prefix, not 'btsctx_'.<br><br>Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172<br>---<br>M TODO-RELEASE<br>M include/osmocom/gprs/gprs_bssgp.h<br>M src/gb/gprs_bssgp.c<br>M src/gb/libosmogb.map<br>4 files changed, 13 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index 9af92c1..692bdc1 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -10,3 +10,4 @@</span><br><span> core osmo_tdef_get() change val_if_not_present arg from unsigned long to long to allow passing -1</span><br><span> core struct osmo_tdef fields min_val,max_val added, ABI break (arrays of structs used in programs)</span><br><span> gsm API added osmo_gsm48_rfpowercap2powerclass()</span><br><span style="color: hsl(120, 100%, 40%);">+gb API added bssgp_bvc_ctx_free()</span><br><span>diff --git a/include/osmocom/gprs/gprs_bssgp.h b/include/osmocom/gprs/gprs_bssgp.h</span><br><span>index 400c3e0..0f87333 100644</span><br><span>--- a/include/osmocom/gprs/gprs_bssgp.h</span><br><span>+++ b/include/osmocom/gprs/gprs_bssgp.h</span><br><span>@@ -112,6 +112,8 @@</span><br><span> struct bssgp_bvc_ctx *btsctx_by_raid_cid(const struct gprs_ra_id *raid, uint16_t cid);</span><br><span> /* Find a BTS context based on BVCI+NSEI tuple */</span><br><span> struct bssgp_bvc_ctx *btsctx_by_bvci_nsei(uint16_t bvci, uint16_t nsei);</span><br><span style="color: hsl(120, 100%, 40%);">+/* Free a given BTS context */</span><br><span style="color: hsl(120, 100%, 40%);">+void bssgp_bvc_ctx_free(struct bssgp_bvc_ctx *ctx);</span><br><span> </span><br><span> #define BVC_F_BLOCKED 0x0001</span><br><span> </span><br><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index b695c28..896f1c5 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -141,6 +141,15 @@</span><br><span> return ctx;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void bssgp_bvc_ctx_free(struct bssgp_bvc_ctx *ctx)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!ctx)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_group_free(ctx->ctrg);</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_del(&ctx->list);</span><br><span style="color: hsl(120, 100%, 40%);">+ talloc_free(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Chapter 10.4.5: Flow Control BVC ACK */</span><br><span> static int bssgp_tx_fc_bvc_ack(uint16_t nsei, uint8_t tag, uint16_t ns_bvci)</span><br><span> {</span><br><span>diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map</span><br><span>index 5e675a6..ad139c1 100644</span><br><span>--- a/src/gb/libosmogb.map</span><br><span>+++ b/src/gb/libosmogb.map</span><br><span>@@ -80,6 +80,7 @@</span><br><span> gprs_log_filter_fn;</span><br><span> </span><br><span> btsctx_alloc;</span><br><span style="color: hsl(120, 100%, 40%);">+bssgp_bvc_ctx_free;</span><br><span> btsctx_by_bvci_nsei;</span><br><span> btsctx_by_raid_cid;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16017">change 16017</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16017"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172 </div>
<div style="display:none"> Gerrit-Change-Number: 16017 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>