<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15976">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15976/3/src/xua_asp_fsm.c">File src/xua_asp_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15976/3/src/xua_asp_fsm.c@642">Patch Set #3, Line 642:</a> <code style="font-family:monospace,monospace">                             S(XUA_ASP_S_DOWN),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since probably xua_asp_fsm_down_onenter() is called, it may make sense to do something like this in there:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (prev_state != XUA_ASP_S_DOWN)<br>  dispatch_to_all_as(fi, XUA_ASPAS_ASP_DOWN_IND);</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Because I don't see the point in annoying upper layers if there's no real change.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15976">change 15976</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15976"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iabbcf92e3022a4c3f165ce19be929915f92b455c </div>
<div style="display:none"> Gerrit-Change-Number: 15976 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 05 Nov 2019 20:02:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>