<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/15957">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/15957/3/include/osmocom/core/utils.h">File include/osmocom/core/utils.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/15957/3/include/osmocom/core/utils.h@300">Patch Set #3, Line 300:</a> <code style="font-family:monospace,monospace">      if (INITIAL_BUFSIZE > 0) { \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">better use (INITIAL_BUFSIZE)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/15957/3/include/osmocom/core/utils.h@324">Patch Set #3, Line 324:</a> <code style="font-family:monospace,monospace">       if (!ON_ERROR) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably add () here, otherwise something in there may take higher priority than the negation mark.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/15957/3/tests/utils/utils_test.c">File tests/utils/utils_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/15957/3/tests/utils/utils_test.c@1127">Patch Set #3, Line 1127:</a> <code style="font-family:monospace,monospace">             </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">whitespace</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/15957">change 15957</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/15957"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ida5ba8d9640ea641aafef0236800f6d489d3d322 </div>
<div style="display:none"> Gerrit-Change-Number: 15957 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 05 Nov 2019 15:39:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>