<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15935">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc-test: improve error log on Assignment RTP port mismatch<br><br>Before this, if an Assignment Request contains an unexpected Transport Layer<br>Address, the test completely rejects the Assignment Request.<br><br>Instead, accept any tla in the Assignment, and compare the expected tla in the<br>Assignment's interleave action. Thus we directly get logging hinting at the tla<br>instead of a T_guard timeout.<br><br>Change-Id: I04847c10d6c3bf9e04cfda6e343dfd4a65be71a5<br>---<br>M msc/BSC_ConnectionHandler.ttcn<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn</span><br><span>index fb2d888..5b0a125 100644</span><br><span>--- a/msc/BSC_ConnectionHandler.ttcn</span><br><span>+++ b/msc/BSC_ConnectionHandler.ttcn</span><br><span>@@ -1044,12 +1044,19 @@</span><br><span>               }</span><br><span> </span><br><span>        //[g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, tla_ass)) -> value bssap {</span><br><span style="color: hsl(0, 100%, 40%);">-       [] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, tla_ass)) -> value bssap {</span><br><span style="color: hsl(120, 100%, 40%);">+  [] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit)) -> value bssap {</span><br><span>          log("f_mo_call_establish 4: rx Assignment Request");</span><br><span>               var BSSMAP_IE_AoIP_TransportLayerAddress tla;</span><br><span>                var BSSMAP_IE_SpeechCodec codec;</span><br><span>             var BSSMAP_IE_Osmo_OsmuxCID osmuxCID;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+             if (tla_ass != bssap.pdu.bssmap.assignmentRequest.aoIPTransportLayer) {</span><br><span style="color: hsl(120, 100%, 40%);">+                       log("Expected:", tla_ass);</span><br><span style="color: hsl(120, 100%, 40%);">+                  log("Got:", bssap.pdu.bssmap.assignmentRequest.aoIPTransportLayer);</span><br><span style="color: hsl(120, 100%, 40%);">+                 setverdict(fail, "MSC sent Assignment Request with unexpected AoIP Transport Layer IE");</span><br><span style="color: hsl(120, 100%, 40%);">+                    mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          tla := valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.bss_rtp_ip), cpars.bss_rtp_port));</span><br><span>           codec := valueof(ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}));</span><br><span>            if (cpars.use_osmux) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15935">change 15935</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15935"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I04847c10d6c3bf9e04cfda6e343dfd4a65be71a5 </div>
<div style="display:none"> Gerrit-Change-Number: 15935 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>