<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/15853">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CC: add error handling for CRCX responses<br><br>Fix three 'FIXME: ERROR HANDLING' occurences in the code that reacts upon the<br>MGW providing (or failing to provide) an RTP port for the RAN side. From an<br>earlier stage of the code, the cleanup for this situation was extremely<br>complex, and hence the choice was to simply wait for the call to time out and<br>fail. But since we have implemented safe deallocation of nested FSMs in<br>libosmocore, the situation has become rather trivial: simply free the CC<br>transactions, and all the rest will immediately release, and terminate<br>correctly without crashing.<br><br>A ttcn3 test for this is MSC_Tests:TC_invalid_mgcp_crash, which actually also<br>needs the change to osmo_sockaddr_str_is_nonzero() in preceding patch<br>I53ddb19a70fda3deb906464e1b89c12d9b4c7cbd, so that a seemingly valid MGCP<br>message ends up causing a failure in the on_success() branch of<br>mgcp_client_endpoint_fsm.c.<br><br>Change-Id: I8313bed1d782100bebeac7d8fc040557c4cb653e<br>---<br>M src/libmsc/msc_a.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c</span><br><span>index d99088e..3c316ea 100644</span><br><span>--- a/src/libmsc/msc_a.c</span><br><span>+++ b/src/libmsc/msc_a.c</span><br><span>@@ -523,7 +523,7 @@</span><br><span> </span><br><span>         if (mncc_bearer_cap_to_channel_type(&channel_type, &cc_trans->bearer_cap)) {</span><br><span>              LOG_MSC_A(msc_a, LOGL_ERROR, "Cannot compose Channel Type from bearer capabilities\n");</span><br><span style="color: hsl(0, 100%, 40%);">-               /* FIXME: ERROR HANDLING */</span><br><span style="color: hsl(120, 100%, 40%);">+           trans_free(cc_trans);</span><br><span>                return;</span><br><span>      }</span><br><span> </span><br><span>@@ -539,7 +539,7 @@</span><br><span>  };</span><br><span>   if (msc_a_ran_down(msc_a, MSC_ROLE_I, &msg)) {</span><br><span>           LOG_MSC_A(msc_a, LOGL_ERROR, "Cannot send Assignment\n");</span><br><span style="color: hsl(0, 100%, 40%);">-             /* FIXME: ERROR HANDLING */</span><br><span style="color: hsl(120, 100%, 40%);">+           trans_free(cc_trans);</span><br><span>                return;</span><br><span>      }</span><br><span> }</span><br><span>@@ -548,7 +548,7 @@</span><br><span> {</span><br><span>    if (gsm48_tch_rtp_create(cc_trans)) {</span><br><span>                LOG_MSC_A(msc_a, LOGL_ERROR, "Cannot inform MNCC of RTP address\n");</span><br><span style="color: hsl(0, 100%, 40%);">-          /* FIXME: ERROR HANDLING */</span><br><span style="color: hsl(120, 100%, 40%);">+           trans_free(cc_trans);</span><br><span>                return;</span><br><span>      }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/15853">change 15853</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/15853"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8313bed1d782100bebeac7d8fc040557c4cb653e </div>
<div style="display:none"> Gerrit-Change-Number: 15853 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>